Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for dreamforce #142

Merged
merged 6 commits into from
Sep 19, 2022
Merged

Fixes for dreamforce #142

merged 6 commits into from
Sep 19, 2022

Conversation

mdonnalley
Copy link
Collaborator

What does this PR do?

  • Generate unit test by default for new commands
  • Remove copyright headers for 3PP

What issues does this PR fix or reference?

[skip-validate-pr]

@mdonnalley mdonnalley self-assigned this Sep 19, 2022
@iowillhoit
Copy link
Contributor

QA NOTES

  • 🟢 new_command.test.ts file created by default
  • 🟢 If external, new commands do not add the copyright to generated files
  • 🟢 Copyright is removed from all files when generating a new external plugin
  • 🟢 ./.eslintrc.js has the copyright rule removed on new external plugins
  • 🟢 Internal plugin files are correct
  • 🟡 Had minor troubles with the copyright still existing on new command files in my existing external plugin. Reason was because the .eslint rule was not removed at plugin creation. The copyright text was not there at generation, but the sf-lint --fix was adding it back. This is an edge case and probably can be ignored. We could consider removing the --fix on dev generate command

@mdonnalley mdonnalley merged commit 05c60cd into main Sep 19, 2022
@mdonnalley mdonnalley deleted the mdonnalley/dreamforce branch September 19, 2022 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants