Skip to content

Commit

Permalink
fix: remove yosay dependency
Browse files Browse the repository at this point in the history
  • Loading branch information
mdonnalley committed Jul 31, 2023
1 parent 3004bbf commit b2a6d7d
Show file tree
Hide file tree
Showing 4 changed files with 4 additions and 9 deletions.
4 changes: 1 addition & 3 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -21,8 +21,7 @@
"shelljs": "^0.8.5",
"tslib": "^2",
"yeoman-environment": "^3.19.3",
"yeoman-generator": "^5.8.0",
"yosay": "^2.0.2"
"yeoman-generator": "^5.8.0"
},
"devDependencies": {
"@oclif/plugin-command-snapshot": "^4.0.9",
Expand All @@ -38,7 +37,6 @@
"@types/shelljs": "^0.8.10",
"@types/yeoman-generator": "^5.2.10",
"@types/yeoman-test": "^4.0.3",
"@types/yosay": "^2.0.1",
"@typescript-eslint/eslint-plugin": "^5.62.0",
"@typescript-eslint/parser": "^5.59.8",
"chai": "^4.3.7",
Expand Down
3 changes: 1 addition & 2 deletions src/generators/command.ts
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@

import * as path from 'path';
import * as Generator from 'yeoman-generator';
import yosay = require('yosay');
import { pascalCase } from 'change-case';
import { set } from '@salesforce/kit';
import { get } from '@salesforce/ts-types';
Expand Down Expand Up @@ -79,7 +78,7 @@ export default class Command extends Generator {
// eslint-disable-next-line @typescript-eslint/require-await
public async prompting(): Promise<void> {
this.pjson = this.fs.readJSON('package.json') as unknown as PackageJson;
this.log(yosay(`Adding a command to ${this.pjson.name} Version: ${version as string}`));
this.log(`Adding a command to ${this.pjson.name}! Version: ${version as string}`);

if (Object.keys(this.pjson.devDependencies).includes('@salesforce/plugin-command-reference')) {
// Get a list of all commands in `sf`. We will use this to determine if a topic is internal or external.
Expand Down
3 changes: 1 addition & 2 deletions src/generators/library.ts
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@
import * as fs from 'fs';
import * as path from 'path';
import * as Generator from 'yeoman-generator';
import yosay = require('yosay');
import { exec } from 'shelljs';
import replace = require('replace-in-file');
import { PackageJson } from '../types';
Expand Down Expand Up @@ -39,7 +38,7 @@ export default class Library extends Generator {
public async prompting(): Promise<void> {
const msg = 'Time to build a library!';

this.log(yosay(`${msg} Version: ${version as string}`));
this.log(`${msg} Version: ${version as string}`);

this.answers = await this.prompt<Answers>([
{
Expand Down
3 changes: 1 addition & 2 deletions src/generators/plugin.ts
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@
import * as fs from 'fs';
import * as path from 'path';
import * as Generator from 'yeoman-generator';
import yosay = require('yosay');
import { exec } from 'shelljs';
import replace = require('replace-in-file');
import { Messages } from '@salesforce/core';
Expand Down Expand Up @@ -42,7 +41,7 @@ export default class Plugin extends Generator {
}

public async prompting(): Promise<void> {
this.log(yosay(messages.getMessage('info.start', [version as string])));
this.log(messages.getMessage('info.start', [version as string]));

this.githubUsername = await this.getGitUsername();

Expand Down

0 comments on commit b2a6d7d

Please sign in to comment.