-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: don't throw when 15 char job ID not in cache #884
Conversation
QA: ✅ deploy with 18 char job-id I've got a fix to make |
@@ -80,7 +80,7 @@ export default class DeployMetadataCancel extends SfCommand<DeployResultJson> { | |||
if (!this.jsonEnabled()) formatter.display(); | |||
return formatter.getJson(); | |||
} else { | |||
const wait = flags.wait ?? Duration.minutes(deployOpts.wait); | |||
const wait = flags.wait ?? Duration.minutes(deployOpts.wait ?? 33); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we update the command help for cancel, report, and resume to note the 33 minute default?
QA: |
What does this PR do?
When a 15 character deploy ID is provided to the quick deploy command, and that job is not in the cache for this CLI, the command will now still continue using the 15 character ID as long as there is a target org found.
What issues does this PR fix or reference?
@W-14800653@