fix: don't truncate at PDR level #654
Conversation
| @@ -74,7 +74,8 @@ export class DeleteResultFormatter implements Formatter<DeleteSourceJson> { | |||
| fullName: { header: 'FULL NAME' }, | |||
| type: { header: 'TYPE' }, | |||
| filePath: { header: 'PROJECT PATH' }, | |||
| } | |||
| }, | |||
There was a problem hiding this comment.
I think I'd rather have the commands instantiate a new sf-plugins/core Ux and pass that to the formatters' constructor. Then future style/ui changes become one-place-to-change.
There's some other UI inconsistencies between Ux and the SfCommand (colored warnings, for example) that we'd get consistency on.
There was a problem hiding this comment.
I looked into that, but it kept expanding what was required when implementing it for the now deprecated project deploy command.
This approach will be the smallest change in the plugin, and if we wanted a one-place-to-change it, we would change this at the oclif level 🤷♂️
There was a problem hiding this comment.
Or maybe if there was another level of inheritance involved that provided common options for all source commands and formatters it could be changed in that one place. Maybe call it, SourceCommand or ResultFormatter.
What does this PR do?
no-truncate table output at the PDR level
What issues does this PR fix or reference?
@W-13003428@
forcedotcom/cli#2048
for when commands call directly into OCLIF's ux.table method don't truncate output