fix: avoid unknown error #652
Conversation
| fileResponsesFromDelete.length === 0 && | ||
| (flags.manifest || flags.metadata || flags['source-dir']) | ||
| ) { | ||
| throw new SfError('No metadata retrieved'); |
There was a problem hiding this comment.
should that even be an error? I think we could print that message and exit 0?
There was a problem hiding this comment.
Steve, yes, will do to go with the STL PR.
Willie...trying to make it match how deploy works (retrieve "changes" can be empty, but retrieves with specified material should not). ref: forcedotcom/cli#2065
There was a problem hiding this comment.
FyI, the retrieve will retrieve an "empty" package.xml so even when nothing retrieves, it still looks like a success. We'd have to do more work to make it NOT do that (ex: check that there's anything in there besides package.xml) so I'm inclined to leave it as a success (the formatter will give a warning since the user probably didn't intend that).
The "there was nothing in the CS for a pull-like retrieve" output also moved to the formatter. It seems to work well.
There's also a NUT that helps make sure that an empty pull-like retrieve is a exit0.
test/nuts/retrieve/metadata.nut.ts
Outdated
| await testkit.retrieve({ args: '--metadata ApexClass' }); | ||
| await testkit.expect.filesToBeRetrieved(['force-app/main/default/classes/*']); | ||
| }); | ||
|
|
There was a problem hiding this comment.
Why are you removing this? Is it covered elsewhere?
test/nuts/tracking/basics.nut.ts
Outdated
| @@ -133,6 +133,13 @@ describe('end-to-end-test for tracking with an org (single packageDir)', () => { | |||
| ); | |||
| }); | |||
|
|
|||
| it('an empty "pull" retrieve is not an error', () => { | |||
There was a problem hiding this comment.
this assertion moved to forceIgnore.nut and I forgot to remove it from basics.
[explanation: there's a profile change here. I had to ignore profiles over in the forceIgnore.nut to ensure an empty "pull"
What does this PR do?
gives better output when nothing is specified (ie pull) and there's nothing to retrieve
adds a NUT for exit code on empty "pull-like" retrieves
add warning for retrieve operations that came back empty
What issues does this PR fix or reference?
forcedotcom/cli#2126 @W-13329259@
QA notes
ui reminder: bin/dev has different styling and more verbose warning output than a linked plugin.
sf-plugin-core ux doesn't seem to style the warning the same way sfCommand does, but that's out of scope for this WI