-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wr/delete custom labels #613
Conversation
@@ -355,7 +355,19 @@ export class Source extends SfCommand<DeleteSourceJson> { | |||
} | |||
} | |||
if (component.xml) { | |||
promises.push(fsPromises.unlink(component.xml)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for every custom label in the CS, this calls STL.deleteCustomLabels on every label in the set.
Some of those are going to be targeted multiple times?
Maybe you want to do that filter of labels once at the top of the method rather than inside the per-component loop
QA notes: retested using https://github.com/forcedotcom/source-tracking/pull/388/files and the corresponding change for PDR. 👍🏻 output messages are good Note: this set of PRs does not modify the behavior of |
What does this PR do?
when a single CL is specified for delete, only delete that label from the CLs file
What issues does this PR fix or reference?
@W-13167950@
forcedotcom/cli#2118