Sm/multiple-flag-bug

[mshanemc]

What does this PR do?

usability improvements to prevent forcedotcom/cli#2117.

explanation: the old commands used comma separated lists for test names. There's no validation on the client or server that the named test actually exists. 🤷🏻

People's tests wouldn't run, but it wasn't an exception. This now provides a warning when you put a comma in the --tests flag OR the --coverage-reporters flag because it's probably a mistake.

What issues does this PR fix or reference?

@W-13168361@

[iowillhoit]

QA NOTES

• 🟢 Replicated error before linking plugin-deploy-retrieve
• 🟢 Using spaces works before linking plugin-deploy-retrieve
• 🟢 Help includes --test flag examples
• 🟡 Running the following command on a fresh Dreamhouse, showed the flag warning twice
  • sf project deploy start --manifest package.xml --test-level RunSpecifiedTests --dry-run --tests "FileUtilitiesTest,GeoCodingServiceTest,TestPropertyController,TestSampleDataController" --ignore-warnings

(node:61928) Warning: The previous version of this command used a comma-separated list for tests. We've changed how you specify multiple tests, so if you continue using your current syntax, your tests will probably not run as you expect.

If a test name contains a space, enclose it in double quotes.
For multiple test names, use one of the following formats:

- Repeat the flag for multiple test names. --tests Test1 --tests Test2 --tests "Test With Space"
- Separate the test names with spaces --tests Test1 Test2 "Test With Space"
(Use `node --trace-warnings ...` to show where the warning was created)
Warning: The previous version of this command used a comma-separated list for tests. We've changed how you specify multiple tests, so if you continue using your current syntax, your tests will probably not run as you expect.

If a test name contains a space, enclose it in double quotes.
For multiple test names, use one of the following formats:

- Repeat the flag for multiple test names. --tests Test1 --tests Test2 --tests "Test With Space"
- Separate the test names with spaces --tests Test1 Test2 "Test With Space"

• 🔴 Huh, after linking (and using spaces) I am getting this error. Seems unrelated to these changes, but maybe surfacing from recent ConfigAggregator changes
  • Error (1): Unknown config name: org-metadata-rest-deploy.

[iowillhoit]

QA UPDATE

• 🟡 Ok, the "Unknown config" is because linked plugins don't honor custom config values. Proceeding with bin/dev
• 🟢 Since warning message when using bin/dev
• 🟢 With commas, a warning is logged and 0 tests pass
• 🟢 With spaces, it works as expected and all tests pass
• 🟢 With multiple '--tests' flags, it works as expected and all tests pass
• 🟡 Looks like the commaWarningForMultipleFlags for coverageFormattersFlag isn't needed. When you pass options it will enforce the correct format (no commas). However, removing the options front that flag config does show your warning. Example:

Running: bin/dev project deploy start --manifest package.xml --test-level RunSpecifiedTests --dry-run --tests FileUtilitiesTest --tests GeoCodingServiceTest --tests TestPropertyController --tests TestSampleDataController --ignore-warnings --coverage-formatters json,html
Error (1): Expected --coverage-formatters=json,html to be one of: clover, cobertura, html-spa, html, json, json-summary, lcovonly, none, teamcity, text, text-summary
See more help with --help

[iowillhoit]

QA UPDATE

• 🟢 Formatters still work after update
• 🟢 Tests still show warning with commas
• 🟢 Tests still work with spaces
• 🟢 Tests still work with multiple --tests flags