fix: respect UT flags when running with json (#650)

salesforcecli · Jun 6, 2023 · 12b002c · 12b002c
1 parent 8c3e3e7
commit 12b002c
Show file tree

Hide file tree

Showing 3 changed files with 30 additions and 1 deletion.
diff --git a/src/formatters/deployResultFormatter.ts b/src/formatters/deployResultFormatter.ts
@@ -68,6 +68,15 @@ export class DeployResultFormatter implements Formatter<DeployResultJson> {
   }
 
   public getJson(): DeployResultJson {
+    // only generate reports if test results are presented
+    if (this.result.response?.numberTestsTotal) {
+      if (this.coverageOptions.reportFormats?.length) {
+        this.createCoverageReport('no-map');
+      }
+      if (this.junit) {
+        this.createJunitResults();
+      }
+    }
     if (this.verbosity === 'concise') {
       return {
         ...this.result.response,
@@ -81,7 +90,7 @@ export class DeployResultFormatter implements Formatter<DeployResultJson> {
       return {
         ...this.result.response,
         files: this.absoluteFiles,
-        ...(this.result.replacements.size
+        ...(this.result.replacements?.size
           ? {
               replacements: Object.fromEntries(this.result.replacements),
             }

diff --git a/test/utils/deployResponses.ts b/test/utils/deployResponses.ts
@@ -194,6 +194,7 @@ export const getDeployResponse = (
         },
       ];
       response.details.runTestResult.numFailures = '0';
+      response.numberTestsTotal = 1;
     }
     response.runTestsEnabled = true;
     response.numberTestErrors = 0;

diff --git a/test/utils/output.test.ts b/test/utils/output.test.ts
@@ -58,6 +58,25 @@ describe('deployResultFormatter', () => {
         });
       });
 
+      it('will write test output when in json mode', async () => {
+        const deployResult = getDeployResult('passedTest');
+        const formatter = new DeployResultFormatter(deployResult, {
+          junit: true,
+          'coverage-formatters': ['text', 'cobertura'],
+        });
+        // private method stub
+        // eslint-disable-next-line @typescript-eslint/ban-ts-comment
+        // @ts-ignore
+        const coverageReportStub = sandbox.stub(formatter, 'createCoverageReport');
+        // private method stub
+        // eslint-disable-next-line @typescript-eslint/ban-ts-comment
+        // @ts-ignore
+        const junitStub = sandbox.stub(formatter, 'createJunitResults');
+        formatter.getJson();
+        expect(coverageReportStub.calledOnce).to.equal(true);
+        expect(junitStub.calledOnce).to.equal(true);
+      });
+
       it('teamcity', () => {
         const result = getCoverageFormattersOptions(['teamcity']);
         expect(result).to.deep.equal({