Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow single quotes in key=value pairs #427

Merged
merged 4 commits into from
Dec 7, 2022
Merged

fix: allow single quotes in key=value pairs #427

merged 4 commits into from
Dec 7, 2022

Conversation

RodEsp
Copy link
Contributor

@RodEsp RodEsp commented Dec 6, 2022

What does this PR do?

Allows using ' in the value of name-value pairs for flags such as force:data:record:create's --values.

What issues does this PR fix or reference?

forcedotcom/cli#1820
@W-12105706@

This lets you use force:data:record:create and force:data:record:update with values that have single quotes
@RodEsp RodEsp requested review from peternhale, WillieRuemmele and a team December 6, 2022 01:37
Copy link
Contributor

@peternhale peternhale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know there are not a lot UTs in this modules, but maybe one or two more around this change.

src/dataCommand.ts Outdated Show resolved Hide resolved
@RodEsp
Copy link
Contributor Author

RodEsp commented Dec 6, 2022

Heya @peternhale, I created #428 so that we can test the behavior of the existing method and make sure that the changes in this PR aren't introducing any regressions.

Once we merge #428 I'll merge main into this PR's branch and use the new unit tests to continue tweaking the regex here.

@RodEsp RodEsp requested a review from peternhale December 7, 2022 06:15
@RodEsp
Copy link
Contributor Author

RodEsp commented Dec 7, 2022

Heya @peternhale, this is ready for another look.

Unfortunately, I could not get the regex to work with both weird Unicode characters and values like key="leftvalue rightvalue" at the same time, so it looks like we're stuck with the current lengthy code that checks for the existence of 's and "s.

Copy link
Contributor

@peternhale peternhale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@RodEsp I found another valid string that does not make it through the function intact, but it probably would of failed in the current code too.

  it('should allow double and single quotes in key=value pairs', () => {
    const dict = dataCommand.testStringToDictionary("key='39° 44' 31.3548\" N'");

    expect(dict).to.deep.equal({
      key: '39° 44\' 31.3548" N',
    });
  });

src/dataCommand.ts Outdated Show resolved Hide resolved
@RodEsp
Copy link
Contributor Author

RodEsp commented Dec 7, 2022

Yeah, that didn't work without the changes in this PR either. The problem is with values that have quoted strings inside quoted strings, e.g. key="this is a 'quote'" or key='this is a "quote"'. I think it'll be a greater effort to get that to work, but for the sake of fixing forcedotcom/cli#1820 asap I'd like to merge this now and I created forcedotcom/cli#1837 to address strings like the one in your unit test later.

@RodEsp RodEsp requested a review from peternhale December 7, 2022 20:12
@RodEsp RodEsp merged commit bcc48e5 into main Dec 7, 2022
@RodEsp RodEsp deleted the re/allow-quotes branch December 7, 2022 20:25
mshanemc added a commit that referenced this pull request Jan 2, 2023
* chore(dev-deps): bump @salesforce/ts-sinon from 1.4.1 to 1.4.2

Bumps [@salesforce/ts-sinon](https://github.com/forcedotcom/ts-sinon) from 1.4.1 to 1.4.2.
- [Release notes](https://github.com/forcedotcom/ts-sinon/releases)
- [Changelog](https://github.com/forcedotcom/ts-sinon/blob/main/CHANGELOG.md)
- [Commits](forcedotcom/ts-sinon@1.4.1...1.4.2)

---
updated-dependencies:
- dependency-name: "@salesforce/ts-sinon"
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>

* fix(deps): bump @salesforce/command from 5.2.20 to 5.2.25

Bumps [@salesforce/command](https://github.com/salesforcecli/command) from 5.2.20 to 5.2.25.
- [Release notes](https://github.com/salesforcecli/command/releases)
- [Changelog](https://github.com/salesforcecli/command/blob/main/CHANGELOG.md)
- [Commits](salesforcecli/command@5.2.20...5.2.25)

---
updated-dependencies:
- dependency-name: "@salesforce/command"
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>

* chore(release): 2.1.12 [skip ci]

* chore(dev-deps): bump @oclif/plugin-command-snapshot

Bumps [@oclif/plugin-command-snapshot](https://github.com/oclif/plugin-command-snapshot) from 3.1.3 to 3.2.10.
- [Release notes](https://github.com/oclif/plugin-command-snapshot/releases)
- [Changelog](https://github.com/oclif/plugin-command-snapshot/blob/main/CHANGELOG.md)
- [Commits](oclif/plugin-command-snapshot@v3.1.3...3.2.10)

---
updated-dependencies:
- dependency-name: "@oclif/plugin-command-snapshot"
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>

* chore: parking orbit cleanup (#413)

* chore(dev-deps): bump @salesforce/plugin-command-reference

Bumps [@salesforce/plugin-command-reference](https://github.com/forcedotcom/plugin-command-reference) from 1.5.0 to 1.5.2.
- [Release notes](https://github.com/forcedotcom/plugin-command-reference/releases)
- [Commits](https://github.com/forcedotcom/plugin-command-reference/commits)

---
updated-dependencies:
- dependency-name: "@salesforce/plugin-command-reference"
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>

* fix(deps): bump @salesforce/command from 5.2.25 to 5.2.27

Bumps [@salesforce/command](https://github.com/salesforcecli/command) from 5.2.25 to 5.2.27.
- [Release notes](https://github.com/salesforcecli/command/releases)
- [Changelog](https://github.com/salesforcecli/command/blob/main/CHANGELOG.md)
- [Commits](salesforcecli/command@5.2.25...5.2.27)

---
updated-dependencies:
- dependency-name: "@salesforce/command"
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>

* chore(release): 2.1.13 [skip ci]

* chore(dev-deps): bump typescript from 4.8.4 to 4.9.3

Bumps [typescript](https://github.com/Microsoft/TypeScript) from 4.8.4 to 4.9.3.
- [Release notes](https://github.com/Microsoft/TypeScript/releases)
- [Commits](microsoft/TypeScript@v4.8.4...v4.9.3)

---
updated-dependencies:
- dependency-name: typescript
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>

* chore(dev-deps): bump prettier from 2.7.1 to 2.8.0

Bumps [prettier](https://github.com/prettier/prettier) from 2.7.1 to 2.8.0.
- [Release notes](https://github.com/prettier/prettier/releases)
- [Changelog](https://github.com/prettier/prettier/blob/main/CHANGELOG.md)
- [Commits](prettier/prettier@2.7.1...2.8.0)

---
updated-dependencies:
- dependency-name: prettier
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>

* chore(dev-deps): bump @salesforce/plugin-command-reference

Bumps [@salesforce/plugin-command-reference](https://github.com/forcedotcom/plugin-command-reference) from 1.5.2 to 1.5.3.
- [Release notes](https://github.com/forcedotcom/plugin-command-reference/releases)
- [Commits](https://github.com/forcedotcom/plugin-command-reference/commits)

---
updated-dependencies:
- dependency-name: "@salesforce/plugin-command-reference"
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>

* fix(deps): bump @salesforce/command from 5.2.27 to 5.2.28

Bumps [@salesforce/command](https://github.com/salesforcecli/command) from 5.2.27 to 5.2.28.
- [Release notes](https://github.com/salesforcecli/command/releases)
- [Changelog](https://github.com/salesforcecli/command/blob/main/CHANGELOG.md)
- [Commits](salesforcecli/command@5.2.27...5.2.28)

---
updated-dependencies:
- dependency-name: "@salesforce/command"
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>

* chore(release): 2.1.14 [skip ci]

* chore: add some unit tests for dataCommand class (#428)

* chore: add some unit tests for dataCommand class

* chore: whoops, remove .only

* fix: edit messages for "data query"

* fix: allow single quotes in key=value pairs (#427)

* fix: allow single quotes in key=value pairs

This lets you use force:data:record:create and force:data:record:update with values that have single quotes

* fix: check if key=value pairs have a quoted string vs just a quote in the value

* chore: change regex exec() to test()

Co-authored-by: peternhale <[email protected]>

Co-authored-by: peternhale <[email protected]>

* chore(release): 2.1.15 [skip ci]

* fix: edit "data record" messages

* fix: edit messages for "data import/export tree" commands

and other error files.

* fix: edit messages for "data bulk upsert"

* fix(deps): bump @salesforce/core from 3.32.6 to 3.32.9

Bumps [@salesforce/core](https://github.com/forcedotcom/sfdx-core) from 3.32.6 to 3.32.9.
- [Release notes](https://github.com/forcedotcom/sfdx-core/releases)
- [Changelog](https://github.com/forcedotcom/sfdx-core/blob/main/CHANGELOG.md)
- [Commits](forcedotcom/sfdx-core@3.32.6...3.32.9)

---
updated-dependencies:
- dependency-name: "@salesforce/core"
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>

* chore(release): 2.1.16 [skip ci]

* fix(deps): bump @salesforce/command from 5.2.28 to 5.2.30

Bumps [@salesforce/command](https://github.com/salesforcecli/command) from 5.2.28 to 5.2.30.
- [Release notes](https://github.com/salesforcecli/command/releases)
- [Changelog](https://github.com/salesforcecli/command/blob/main/CHANGELOG.md)
- [Commits](salesforcecli/command@5.2.28...5.2.30)

---
updated-dependencies:
- dependency-name: "@salesforce/command"
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>

* chore(dev-deps): bump oclif from 3.2.28 to 3.4.2

Bumps [oclif](https://github.com/oclif/oclif) from 3.2.28 to 3.4.2.
- [Release notes](https://github.com/oclif/oclif/releases)
- [Changelog](https://github.com/oclif/oclif/blob/main/CHANGELOG.md)
- [Commits](oclif/oclif@3.2.28...3.4.2)

---
updated-dependencies:
- dependency-name: oclif
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>

* chore(dev-deps): bump @swc/core from 1.3.16 to 1.3.22

Bumps [@swc/core](https://github.com/swc-project/swc) from 1.3.16 to 1.3.22.
- [Release notes](https://github.com/swc-project/swc/releases)
- [Changelog](https://github.com/swc-project/swc/blob/main/CHANGELOG.md)
- [Commits](swc-project/swc@v1.3.16...v1.3.22)

---
updated-dependencies:
- dependency-name: "@swc/core"
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>

* chore(release): 2.1.17 [skip ci]

* fix: edit messages for "data bulk upsert"

* fix: edit "data bulk" messages

* fix: edit "data query resume" messages

* fix: fix tests that hard-code error messages

* chore(dev-deps): bump @swc/core from 1.3.22 to 1.3.23

Bumps [@swc/core](https://github.com/swc-project/swc) from 1.3.22 to 1.3.23.
- [Release notes](https://github.com/swc-project/swc/releases)
- [Changelog](https://github.com/swc-project/swc/blob/main/CHANGELOG.md)
- [Commits](swc-project/swc@v1.3.22...v1.3.23)

---
updated-dependencies:
- dependency-name: "@swc/core"
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>

* chore: cleanup from messages audit

* test: avoid hardcoding messages in tests

* chore: remove unused flag

* fix: edit based on Shane's feedback

* fix: input Shane's feedback

* fix: update --sobject flag description to say "api name..."

* chore: deprecate cmd aliases

* chore: dependency bumps and strict null checks

* refactor: test null exceptions

* chore: bump linter

* test: nuts don't hardcode command name

* chore: bump csv-stringify

* chore: lockfile and snapshot

* chore: bump testkit

* test: nut with more generic command message

* refactor: make flags readonly

* chore: bump linter

* test: fix regex output validation

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: svc-cli-bot <[email protected]>
Co-authored-by: svc-cli-bot <[email protected]>
Co-authored-by: Willhoit <[email protected]>
Co-authored-by: Rodrigo Espinosa de los Monteros <[email protected]>
Co-authored-by: peternhale <[email protected]>
Co-authored-by: mshanemc <[email protected]>
WillieRuemmele added a commit that referenced this pull request Jan 10, 2023
* chore: updates from devScripts

* refactor: command flag errors

* feat: uses sf-plugins-core

* chore: bump pluginCore and core

* test: all nuts as passing

* refactor: small pruning

* refactor: current tsconfig; tests build but fail

* chore: bump sfCommand

* chore: remove mkdir types

* test: ut all working as before

* chore: snapshot

* chore: use sf commandRef

* test: refactor tests

* docs: description on bulk delete

* refactor: convert messages to md

* refactor: simplify examples

* test: use static run method where not awaiting results

* test: use testsession's new huborg prop

* chore: bump core

* refactor: reorganize command tree

* test: reorganize test folders to match commands

* refactor: message files flags start with flags

* feat: apiVersion on connections

* chore: swc

* feat: tighter checks on salesforce IDs

* style: loadMessages for examples

* docs: sf-ify messages, dynamic bin/command

* refactor: use new versioned connection from core

* chore: bump core for versioned connections

* test: harden nuts for bulk checks

* test: remove ut for unstubbable bulk

* chore: bump core, sf-plugins

* refactor: flags from sf-plugins

* chore: snapshot

* docs: redo topic structure

* docs: subtopics

* chore: revert tsconfig

* refactor: import paths for link error

* docs: remove perflog references in help

* chore: bump sf-plugins-core

* chore: lockfile dedupe

* refactor: use array flag from sf-plugins-core

* chore: deprecate cmd aliases

* chore: dependency bumps and strict null checks

* refactor: test null exceptions

* chore: bump linter

* docs: modernize messages

* chore(dev-deps): bump @salesforce/ts-sinon from 1.4.1 to 1.4.2

Bumps [@salesforce/ts-sinon](https://github.com/forcedotcom/ts-sinon) from 1.4.1 to 1.4.2.
- [Release notes](https://github.com/forcedotcom/ts-sinon/releases)
- [Changelog](https://github.com/forcedotcom/ts-sinon/blob/main/CHANGELOG.md)
- [Commits](forcedotcom/ts-sinon@1.4.1...1.4.2)

---
updated-dependencies:
- dependency-name: "@salesforce/ts-sinon"
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>

* fix(deps): bump @salesforce/command from 5.2.20 to 5.2.25

Bumps [@salesforce/command](https://github.com/salesforcecli/command) from 5.2.20 to 5.2.25.
- [Release notes](https://github.com/salesforcecli/command/releases)
- [Changelog](https://github.com/salesforcecli/command/blob/main/CHANGELOG.md)
- [Commits](salesforcecli/command@5.2.20...5.2.25)

---
updated-dependencies:
- dependency-name: "@salesforce/command"
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>

* chore(release): 2.1.12 [skip ci]

* chore(dev-deps): bump @oclif/plugin-command-snapshot

Bumps [@oclif/plugin-command-snapshot](https://github.com/oclif/plugin-command-snapshot) from 3.1.3 to 3.2.10.
- [Release notes](https://github.com/oclif/plugin-command-snapshot/releases)
- [Changelog](https://github.com/oclif/plugin-command-snapshot/blob/main/CHANGELOG.md)
- [Commits](oclif/plugin-command-snapshot@v3.1.3...3.2.10)

---
updated-dependencies:
- dependency-name: "@oclif/plugin-command-snapshot"
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>

* chore: parking orbit cleanup (#413)

* chore(dev-deps): bump @salesforce/plugin-command-reference

Bumps [@salesforce/plugin-command-reference](https://github.com/forcedotcom/plugin-command-reference) from 1.5.0 to 1.5.2.
- [Release notes](https://github.com/forcedotcom/plugin-command-reference/releases)
- [Commits](https://github.com/forcedotcom/plugin-command-reference/commits)

---
updated-dependencies:
- dependency-name: "@salesforce/plugin-command-reference"
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>

* fix(deps): bump @salesforce/command from 5.2.25 to 5.2.27

Bumps [@salesforce/command](https://github.com/salesforcecli/command) from 5.2.25 to 5.2.27.
- [Release notes](https://github.com/salesforcecli/command/releases)
- [Changelog](https://github.com/salesforcecli/command/blob/main/CHANGELOG.md)
- [Commits](salesforcecli/command@5.2.25...5.2.27)

---
updated-dependencies:
- dependency-name: "@salesforce/command"
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>

* chore(release): 2.1.13 [skip ci]

* chore(dev-deps): bump typescript from 4.8.4 to 4.9.3

Bumps [typescript](https://github.com/Microsoft/TypeScript) from 4.8.4 to 4.9.3.
- [Release notes](https://github.com/Microsoft/TypeScript/releases)
- [Commits](microsoft/TypeScript@v4.8.4...v4.9.3)

---
updated-dependencies:
- dependency-name: typescript
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>

* chore(dev-deps): bump prettier from 2.7.1 to 2.8.0

Bumps [prettier](https://github.com/prettier/prettier) from 2.7.1 to 2.8.0.
- [Release notes](https://github.com/prettier/prettier/releases)
- [Changelog](https://github.com/prettier/prettier/blob/main/CHANGELOG.md)
- [Commits](prettier/prettier@2.7.1...2.8.0)

---
updated-dependencies:
- dependency-name: prettier
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>

* chore(dev-deps): bump @salesforce/plugin-command-reference

Bumps [@salesforce/plugin-command-reference](https://github.com/forcedotcom/plugin-command-reference) from 1.5.2 to 1.5.3.
- [Release notes](https://github.com/forcedotcom/plugin-command-reference/releases)
- [Commits](https://github.com/forcedotcom/plugin-command-reference/commits)

---
updated-dependencies:
- dependency-name: "@salesforce/plugin-command-reference"
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>

* fix(deps): bump @salesforce/command from 5.2.27 to 5.2.28

Bumps [@salesforce/command](https://github.com/salesforcecli/command) from 5.2.27 to 5.2.28.
- [Release notes](https://github.com/salesforcecli/command/releases)
- [Changelog](https://github.com/salesforcecli/command/blob/main/CHANGELOG.md)
- [Commits](salesforcecli/command@5.2.27...5.2.28)

---
updated-dependencies:
- dependency-name: "@salesforce/command"
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>

* chore(release): 2.1.14 [skip ci]

* chore: add some unit tests for dataCommand class (#428)

* chore: add some unit tests for dataCommand class

* chore: whoops, remove .only

* fix: edit messages for "data query"

* fix: allow single quotes in key=value pairs (#427)

* fix: allow single quotes in key=value pairs

This lets you use force:data:record:create and force:data:record:update with values that have single quotes

* fix: check if key=value pairs have a quoted string vs just a quote in the value

* chore: change regex exec() to test()

Co-authored-by: peternhale <[email protected]>

Co-authored-by: peternhale <[email protected]>

* chore(release): 2.1.15 [skip ci]

* fix: edit "data record" messages

* fix: edit messages for "data import/export tree" commands

and other error files.

* fix: edit messages for "data bulk upsert"

* fix(deps): bump @salesforce/core from 3.32.6 to 3.32.9

Bumps [@salesforce/core](https://github.com/forcedotcom/sfdx-core) from 3.32.6 to 3.32.9.
- [Release notes](https://github.com/forcedotcom/sfdx-core/releases)
- [Changelog](https://github.com/forcedotcom/sfdx-core/blob/main/CHANGELOG.md)
- [Commits](forcedotcom/sfdx-core@3.32.6...3.32.9)

---
updated-dependencies:
- dependency-name: "@salesforce/core"
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>

* chore(release): 2.1.16 [skip ci]

* fix(deps): bump @salesforce/command from 5.2.28 to 5.2.30

Bumps [@salesforce/command](https://github.com/salesforcecli/command) from 5.2.28 to 5.2.30.
- [Release notes](https://github.com/salesforcecli/command/releases)
- [Changelog](https://github.com/salesforcecli/command/blob/main/CHANGELOG.md)
- [Commits](salesforcecli/command@5.2.28...5.2.30)

---
updated-dependencies:
- dependency-name: "@salesforce/command"
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>

* chore(dev-deps): bump oclif from 3.2.28 to 3.4.2

Bumps [oclif](https://github.com/oclif/oclif) from 3.2.28 to 3.4.2.
- [Release notes](https://github.com/oclif/oclif/releases)
- [Changelog](https://github.com/oclif/oclif/blob/main/CHANGELOG.md)
- [Commits](oclif/oclif@3.2.28...3.4.2)

---
updated-dependencies:
- dependency-name: oclif
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>

* chore(dev-deps): bump @swc/core from 1.3.16 to 1.3.22

Bumps [@swc/core](https://github.com/swc-project/swc) from 1.3.16 to 1.3.22.
- [Release notes](https://github.com/swc-project/swc/releases)
- [Changelog](https://github.com/swc-project/swc/blob/main/CHANGELOG.md)
- [Commits](swc-project/swc@v1.3.16...v1.3.22)

---
updated-dependencies:
- dependency-name: "@swc/core"
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>

* chore(release): 2.1.17 [skip ci]

* fix: edit messages for "data bulk upsert"

* fix: edit "data bulk" messages

* fix: edit "data query resume" messages

* fix: fix tests that hard-code error messages

* chore(dev-deps): bump @swc/core from 1.3.22 to 1.3.23

Bumps [@swc/core](https://github.com/swc-project/swc) from 1.3.22 to 1.3.23.
- [Release notes](https://github.com/swc-project/swc/releases)
- [Changelog](https://github.com/swc-project/swc/blob/main/CHANGELOG.md)
- [Commits](swc-project/swc@v1.3.22...v1.3.23)

---
updated-dependencies:
- dependency-name: "@swc/core"
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>

* chore: cleanup from messages audit

* test: avoid hardcoding messages in tests

* chore: remove unused flag

* fix: edit based on Shane's feedback

* fix: input Shane's feedback

* fix: update --sobject flag description to say "api name..."

* chore: deprecate cmd aliases

* chore: dependency bumps and strict null checks

* refactor: test null exceptions

* chore: bump linter

* test: nuts don't hardcode command name

* chore: bump csv-stringify

* chore: lockfile and snapshot

* chore: bump testkit

* test: nut with more generic command message

* refactor: make flags readonly

* chore: bump linter

* test: fix regex output validation

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: svc-cli-bot <[email protected]>
Co-authored-by: svc-cli-bot <[email protected]>
Co-authored-by: Willhoit <[email protected]>
Co-authored-by: Rodrigo Espinosa de los Monteros <[email protected]>
Co-authored-by: peternhale <[email protected]>
Co-authored-by: mshanemc <[email protected]>

* chore: add schema check

* fix: messages not used in help can't reference command's config/id

* style: typo from qa

* style: more message template fixes

* style: readme and more typos from QA

* style: better message for multiple record scenario

* fix: message, then error name

* style: markdown formatting

* test: assert message that's really a message message

* doc: try fixing in web UI

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: SF-CLI-BOT <[email protected]>
Co-authored-by: Juliet Shackell <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: svc-cli-bot <[email protected]>
Co-authored-by: svc-cli-bot <[email protected]>
Co-authored-by: Willhoit <[email protected]>
Co-authored-by: Rodrigo Espinosa de los Monteros <[email protected]>
Co-authored-by: peternhale <[email protected]>
Co-authored-by: Willie Ruemmele <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants