fix: regex lightning is surrounded by period

[mshanemc]

What does this PR do?

allows foo-lightning.my.salesforce.com login urls

@W-13639832@

What issues does this PR fix or reference?

forcedotcom/cli#2241

[WillieRuemmele]

QA Notes

---

before

 ➜  sfdx org:login:web --instance-url="https://mycompanyname-lightning.my.salesforce.com"
Error (1): Invalid instance URL. It should NOT be a lightning domain.

Try this:

If you specify an --instance-url value, this value overrides the sfdcLoginUrl value in your sfdx-project.json file.

To specify a My Domain URL, use the format https://yourcompanyname.my.salesforce.com.

To specify a sandbox, set --instance-url to https://MyDomainName--SandboxName.sandbox.my.salesforce.com.

✅ : after opens a browser with that domain

✅ : reads from sfdx-project.json correctly
"sfdcLoginUrl": "https://mycompanyname-lightning.my.salesforce.com",

✅ : deploy a new domain in a scratch org with "lightning" in the name, and then do a round trip org web login

[melvincanafranca]

This is still not working for domains like https://company—uat.sandbox.lightning.force.com. I am still getting the same error that domains with lightning text are not allowed.

[cristiand391]

@melvincanafranca can you please open a new issue? https://github.com/forcedotcom/cli/issues/new?assignees=&labels=investigating&projects=&template=bug_report.md&title=

make sure to follow the template so we can ensure you are using a version that includes this fix 👍🏼 .