Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use d as short form of setdefaultdevhubusername flag #359

Merged
merged 2 commits into from
Jan 31, 2022
Merged

fix: use d as short form of setdefaultdevhubusername flag #359

merged 2 commits into from
Jan 31, 2022

Conversation

amtrack
Copy link
Contributor

@amtrack amtrack commented Jan 29, 2022

What does this PR do?

The short flag s was currently assigned to two flags.
This change now aligns the short form of the flags
with other commands of this plugin:

  • s for setdefaultusername
  • d for setdefaultdevhubusername

What issues does this PR fix or reference?

The short flag -s was setting the defaultdevhubusername config instead of setdefaultusername.

The short flag `s` was currently assigned to two flags.
This change now aligns the short form of the flags
with other commands of this plugin:

 - `s` for `setdefaultusername`
 - `d` for `setdefaultdevhubusername`
@mshanemc mshanemc added bug Something isn't working and removed bug Something isn't working labels Jan 31, 2022
@uip-robot-zz
Copy link

This issue has been linked to a new work item: W-10511865

@mshanemc
Copy link
Contributor

QA Notes:
✅ helptext is correct now
✅ readme looks good

@mshanemc mshanemc merged commit 7b6ff32 into salesforcecli:main Jan 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working cla:signed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants