fix: should throw error with message

salesforcecli · Jan 28, 2021 · 95d53dd · 95d53dd
1 parent 4fab128
commit 95d53dd
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 5 deletions.
diff --git a/messages/web.login.json b/messages/web.login.json
@@ -6,5 +6,5 @@
     "sfdx auth:web:login -r https://test.salesforce.com"
   ],
   "deviceWarning": "auth:web:login doesn't work when authorizing to a headless environment. Use auth:device:login instead.",
-  "invalidClientId": "Invalid client credentials. Verify the OAuth client secret and ID."
+  "invalidClientId": "Invalid client credentials. Verify the OAuth client secret and ID. %s"
 }
diff --git a/src/commands/auth/web/login.ts b/src/commands/auth/web/login.ts
@@ -80,12 +80,11 @@ export default class Login extends SfdxCommand {
       this.ux.log(successMsg);
       return fields;
     } catch (err) {
+      this.logger.debug(err);
       if (err.name === 'AuthCodeExchangeError') {
-        this.ux.error(messages.getMessage('invalidClientId'));
-      } else {
-        this.ux.error(err.message);
+        throw new SfdxError(messages.getMessage('invalidClientId', [err.message]));
       }
-      return {};
+      throw err;
     }
   }