Re/rename mac pkg (#14)

* feat: rename intel mac pkg

* chore: add env var to avoid unnecessary aws API calls

more info here: aws/aws-cli#5262 (comment)

* fix: don't use docker since gha runners already have aws cli

* chore: change rename mac pkg job to a composite action

* chore: for testing

* fix: step ids

* Revert "chore: for testing"

This reverts commit cf409ca.

* fix: remove rename mac job from reusable workflow

* fix: don't hardcode sfdx

* fix: add .pkg file extension

.github/actions/renameMacPkg/action.yml

@@ -16,7 +16,7 @@ runs:
   steps:
     - id: download-and-rename-x64-pkg
       shell: bash
-      run: aws s3 cp s3://dfc-data-production/media/salesforce-cli/${{ inputs.cli }}/channels/${{ inputs.channel }}/sfdx-x64.pkg ./sfdx.pkg
+      run: aws s3 cp s3://dfc-data-production/media/salesforce-cli/${{ inputs.cli }}/channels/${{ inputs.channel }}/${{ inputs.cli }}-x64.pkg ./${{ inputs.cli }}.pkg
     - id: upload-renamed-pkg
       shell: bash
-      run: aws s3 cp ./sfdx.pkg s3://dfc-data-production/media/salesforce-cli/${{ inputs.cli }}/channels/${{ inputs.channel }}/
+      run: aws s3 cp ./${{ inputs.cli }}.pkg s3://dfc-data-production/media/salesforce-cli/${{ inputs.cli }}/channels/${{ inputs.channel }}/