Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wr/twinning #452

Merged
merged 10 commits into from
Dec 13, 2022
Merged

Wr/twinning #452

merged 10 commits into from
Dec 13, 2022

Conversation

WillieRuemmele
Copy link
Contributor

@WillieRuemmele WillieRuemmele commented Dec 6, 2022

What does this PR do?

Adds --dev-debug flag with enhancements
You can now --dev-debug --debug-filter sf:config to limit DEBUG statements
✅ : the current promote-verify uses the correct command

Acceptance Criteria

run a command with --dev-debug to see the debug output, should be equivalent to setting DEBUG=* before running a command

Testing Notes

--dev-debug results in * debug statements
--dev-debug --debug-filter <filter> will filter the debug statements

Checklist

  • This change has been approved by the CLI Review Board or approval isn't required. Anything that adds/changes/deletes commands, flags, output, or json output has to be reviewed.
  • Does this follow the deprecation policy?

What issues does this PR fix or reference?

@W-12152987@

@WillieRuemmele WillieRuemmele requested a review from a team December 6, 2022 20:19
src/flags.ts Outdated Show resolved Hide resolved
src/flags.ts Outdated Show resolved Hide resolved
src/flags.ts Outdated Show resolved Hide resolved
src/flags.ts Outdated Show resolved Hide resolved
src/versions.ts Outdated Show resolved Hide resolved
mshanemc
mshanemc previously approved these changes Dec 9, 2022
@mshanemc
Copy link
Contributor

QA notes

./bin/run env list --dev-debug
✅ does all the debug output as expected
✅ ran with a few flags (--sort with a value, --help) after --dev-debug
✅ ran with a non-* debug value (sf:core) and saw only those logs

example from the comments
config get --dev-debug target-dev-hub --json
❌ command fails with NoConfigKeysFoundError (code is deleting the required argument after --dev-debug)
💡 what if this code ensured that, if present, --dev-debug is the last arg (or penultimate arg if followed by a non-flag value) ? I'm not sure there's a good way to tell an arg from a debug value

src/flags.ts Outdated Show resolved Hide resolved
src/flags.ts Outdated Show resolved Hide resolved
mshanemc
mshanemc previously approved these changes Dec 13, 2022
@mshanemc
Copy link
Contributor

QA notes:

previous issue fixed. Tried all of
./bin/run config get --debug-filter sf:core target-dev-hub --dev-debug
./bin/run config get --debug-filter sf:core target-dev-hub
./bin/run config get --dev-debug --debug-filter sf:core target-dev-hub
./bin/run config get --dev-debug --debug-filter target-dev-hub

All passed/failed as expected.

@mshanemc mshanemc merged commit a120be7 into main Dec 13, 2022
@mshanemc mshanemc deleted the wr/twinning branch December 13, 2022 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants