Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: prompt when single partial command match #1180

Merged
merged 2 commits into from
Sep 28, 2023
Merged

feat: prompt when single partial command match #1180

merged 2 commits into from
Sep 28, 2023

Conversation

mdonnalley
Copy link
Contributor

What does this PR do?

Prompt users to select matching command even when partial command yielded only one match

What issues does this PR fix or reference?

@W-14196793@

mshanemc
mshanemc approved these changes Sep 28, 2023
View reviewed changes
Copy link
Contributor

@mshanemc mshanemc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA notes: shows the one command. It's a bit weird being asked to choose from a list of one, but not enough that I'd want to have another code path/experience to handle the confirmation.

@mshanemc mshanemc merged commit fb0c960 into main Sep 28, 2023
29 checks passed
@mshanemc mshanemc deleted the mdonnalley/prompt-single-matches branch September 28, 2023 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mshanemc mshanemc mshanemc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mdonnalley @mshanemc