Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: windows tarballs #1130

Merged
merged 7 commits into from
Sep 14, 2023
Merged

test: windows tarballs #1130

merged 7 commits into from
Sep 14, 2023

Conversation

mdonnalley
Copy link
Contributor

@mdonnalley mdonnalley commented Sep 8, 2023 •
edited
Loading

What does this PR do?

Run JIT tests for linux and windows

Depends on salesforcecli/plugin-release-management#868

What issues does this PR fix or reference?

@W-14096048@

@mdonnalley mdonnalley marked this pull request as draft September 8, 2023 19:36
@mdonnalley mdonnalley marked this pull request as ready for review September 8, 2023 22:08
iowillhoit
iowillhoit reviewed Sep 13, 2023
View reviewed changes
package.json Outdated Show resolved Hide resolved
@iowillhoit
Copy link
Contributor

You'll need to remove the --cli sf from the package.json
"test:smoke-unix": "sf-release cli:tarballs:smoke --cli sf",

@iowillhoit iowillhoit merged commit d9823a0 into main Sep 14, 2023
12 checks passed
@iowillhoit iowillhoit deleted the mdonnalley/test-windows-tarballs branch September 14, 2023 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iowillhoit iowillhoit iowillhoit approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mdonnalley @iowillhoit