-
Notifications
You must be signed in to change notification settings - Fork 132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sloop was not able to reduce the size on disk after GC runs. This also plays a big role in memory consumption. #114
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
passing on a few comments - still reviewing (sorry, keep getting distracted)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some more comments - still trying to grok all of the delete key / drop prefix logic
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
more comments
left a few comments |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, make sure address comments from @duke-harlan, if there is a separate PR needed, please create the PR or issue so that we can track of it, thank you!
PR includes following changes:
Drop Prefix VS Delete Keys
![image](https://user-images.githubusercontent.com/57542098/79608213-6de87280-80a9-11ea-95f3-fdc75f6b04ad.png)
In first 12 hours GC was run using Drop Prefix and rest of 12 hours were run using Delete Prefix
Debug Page showing internal keys info: