Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(engine): fixes #973 to support cloneNode with ie11 devtool comment #980

Merged
merged 1 commit into from
Jan 18, 2019
Merged

fix(engine): fixes #973 to support cloneNode with ie11 devtool comment #980

merged 1 commit into from
Jan 18, 2019

Conversation

caridy
Copy link
Collaborator

@caridy caridy commented Jan 17, 2019

Cherry pick from #974

@caridy
fix(engine): fixes #973 to support cloneNode with ie11 devtool comment (
b6cd416 
#974)

* fix(engine): fixes #973 to support cloneNode with ie11 devtool comment
* fix(engine): fix for devtool logging of -bash on a root custom element
* fix(engine): more guarding around isNodeSlotted for inserted nodes
@salesforce-best-lwc-internal
Copy link

Benchmark results

Base commit: 4931eec | Target commit: b6cd416

lwc-engine-benchmark

table-append-1k metric base(4931eec) target(b6cd416) trend
benchmark-table/append/1k duration 153.70 (±5.05 ms) 148.80 (±4.60 ms) -4.9ms (3.2%) 👍
table-clear-1k metric base(4931eec) target(b6cd416) trend
benchmark-table/clear/1k duration 6.10 (±0.45 ms) 6.10 (±0.50 ms) 0.0ms (0.0%) 👌
table-create-10k metric base(4931eec) target(b6cd416) trend
benchmark-table/create/10k duration 917.40 (±4.60 ms) 876.75 (±6.60 ms) -40.6ms (4.4%) 👍
table-create-1k metric base(4931eec) target(b6cd416) trend
benchmark-table/create/1k duration 118.85 (±3.80 ms) 116.60 (±3.95 ms) -2.3ms (1.9%) 👍
table-update-10th-1k metric base(4931eec) target(b6cd416) trend
benchmark-table/update-10th/1k duration 76.10 (±2.10 ms) 76.65 (±3.10 ms) +0.6ms (0.7%) 👌
tablecmp-append-1k metric base(4931eec) target(b6cd416) trend
benchmark-table-component/append/1k duration 253.65 (±4.95 ms) 244.55 (±9.50 ms) -9.1ms (3.6%) 👍
tablecmp-clear-1k metric base(4931eec) target(b6cd416) trend
benchmark-table-component/clear/1k duration 12.20 (±1.75 ms) 12.10 (±1.75 ms) -0.1ms (0.8%) 👌
tablecmp-create-10k metric base(4931eec) target(b6cd416) trend
benchmark-table-component/create/10k duration 1754.45 (±17.00 ms) 1707.30 (±16.20 ms) -47.1ms (2.7%) 👍
tablecmp-create-1k metric base(4931eec) target(b6cd416) trend
benchmark-table-component/create/1k duration 211.50 (±6.55 ms) 206.45 (±5.05 ms) -5.1ms (2.4%) 👍
tablecmp-update-10th-1k metric base(4931eec) target(b6cd416) trend
benchmark-table-component/update-10th/1k duration 72.75 (±5.10 ms) 71.75 (±5.90 ms) -1.0ms (1.4%) 👌
wc-append-1k metric base(4931eec) target(b6cd416) trend
benchmark-table-wc/append/1k duration 263.70 (±6.30 ms) 256.90 (±4.50 ms) -6.8ms (2.6%) 👍
wc-clear-1k metric base(4931eec) target(b6cd416) trend
benchmark-table-wc/clear/1k duration 22.10 (±1.65 ms) 21.80 (±2.25 ms) -0.3ms (1.4%) 👌
wc-create-10k metric base(4931eec) target(b6cd416) trend
benchmark-table-wc/create/10k duration 1983.70 (±9.25 ms) 1897.10 (±14.55 ms) -86.6ms (4.4%) 👍
wc-create-1k metric base(4931eec) target(b6cd416) trend
benchmark-table-wc/create/1k duration 228.90 (±5.80 ms) 219.35 (±4.15 ms) -9.6ms (4.2%) 👍
wc-update-10th-1k metric base(4931eec) target(b6cd416) trend
benchmark-table-wc/update-10th/1k duration 71.40 (±5.25 ms) 73.30 (±5.05 ms) +1.9ms (2.7%) 👌

@caridy caridy added this to the 218 milestone Jan 18, 2019
@salesforce-best-lwc-internal
Copy link

Benchmark results

Base commit: 0ec65ea | Target commit: b6cd416

lwc-engine-benchmark

table-append-1k metric base(0ec65ea) target(b6cd416) trend
benchmark-table/append/1k duration 150.60 (±5.75 ms) 147.30 (±3.15 ms) -3.3ms (2.2%) 👍
table-clear-1k metric base(0ec65ea) target(b6cd416) trend
benchmark-table/clear/1k duration 6.30 (±0.50 ms) 5.80 (±0.30 ms) -0.5ms (7.9%) 👍
table-create-10k metric base(0ec65ea) target(b6cd416) trend
benchmark-table/create/10k duration 910.35 (±6.40 ms) 873.15 (±5.90 ms) -37.2ms (4.1%) 👍
table-create-1k metric base(0ec65ea) target(b6cd416) trend
benchmark-table/create/1k duration 122.00 (±3.70 ms) 113.85 (±2.55 ms) -8.2ms (6.7%) 👍
table-update-10th-1k metric base(0ec65ea) target(b6cd416) trend
benchmark-table/update-10th/1k duration 86.75 (±2.25 ms) 87.05 (±2.95 ms) +0.3ms (0.3%) 👌
tablecmp-append-1k metric base(0ec65ea) target(b6cd416) trend
benchmark-table-component/append/1k duration 256.30 (±7.85 ms) 237.20 (±14.85 ms) -19.1ms (7.5%) 👍
tablecmp-clear-1k metric base(0ec65ea) target(b6cd416) trend
benchmark-table-component/clear/1k duration 12.40 (±1.65 ms) 11.95 (±2.00 ms) -0.5ms (3.6%) 👌
tablecmp-create-10k metric base(0ec65ea) target(b6cd416) trend
benchmark-table-component/create/10k duration 1787.00 (±22.80 ms) 1699.35 (±11.35 ms) -87.7ms (4.9%) 👍
tablecmp-create-1k metric base(0ec65ea) target(b6cd416) trend
benchmark-table-component/create/1k duration 215.30 (±4.35 ms) 207.45 (±7.35 ms) -7.9ms (3.6%) 👍
tablecmp-update-10th-1k metric base(0ec65ea) target(b6cd416) trend
benchmark-table-component/update-10th/1k duration 70.15 (±5.25 ms) 68.55 (±5.15 ms) -1.6ms (2.3%) 👌
wc-append-1k metric base(0ec65ea) target(b6cd416) trend
benchmark-table-wc/append/1k duration 260.60 (±5.40 ms) 251.45 (±8.75 ms) -9.2ms (3.5%) 👍
wc-clear-1k metric base(0ec65ea) target(b6cd416) trend
benchmark-table-wc/clear/1k duration 23.00 (±1.75 ms) 21.50 (±1.85 ms) -1.5ms (6.5%) 👍
wc-create-10k metric base(0ec65ea) target(b6cd416) trend
benchmark-table-wc/create/10k duration 1963.65 (±16.35 ms) 1859.10 (±10.10 ms) -104.6ms (5.3%) 👍
wc-create-1k metric base(0ec65ea) target(b6cd416) trend
benchmark-table-wc/create/1k duration 226.05 (±5.65 ms) 220.20 (±5.40 ms) -5.9ms (2.6%) 👍
wc-update-10th-1k metric base(0ec65ea) target(b6cd416) trend
benchmark-table-wc/update-10th/1k duration 71.10 (±5.85 ms) 71.90 (±4.75 ms) +0.8ms (1.1%) 👌

@salesforce-best-lwc-internal
Copy link

Benchmark results

Base commit: 0ec65ea | Target commit: b6cd416

lwc-engine-benchmark

table-append-1k metric base(0ec65ea) target(b6cd416) trend
benchmark-table/append/1k duration 150.60 (±5.75 ms) 147.55 (±5.35 ms) -3.0ms (2.0%) 👌
table-clear-1k metric base(0ec65ea) target(b6cd416) trend
benchmark-table/clear/1k duration 6.30 (±0.50 ms) 5.80 (±0.40 ms) -0.5ms (7.9%) 👍
table-create-10k metric base(0ec65ea) target(b6cd416) trend
benchmark-table/create/10k duration 910.35 (±6.40 ms) 871.75 (±7.60 ms) -38.6ms (4.2%) 👍
table-create-1k metric base(0ec65ea) target(b6cd416) trend
benchmark-table/create/1k duration 122.00 (±3.70 ms) 117.05 (±2.80 ms) -5.0ms (4.1%) 👍
table-update-10th-1k metric base(0ec65ea) target(b6cd416) trend
benchmark-table/update-10th/1k duration 86.75 (±2.25 ms) 74.85 (±2.55 ms) -11.9ms (13.7%) 👍
tablecmp-append-1k metric base(0ec65ea) target(b6cd416) trend
benchmark-table-component/append/1k duration 256.30 (±7.85 ms) 232.75 (±19.40 ms) -23.6ms (9.2%) 👍
tablecmp-clear-1k metric base(0ec65ea) target(b6cd416) trend
benchmark-table-component/clear/1k duration 12.40 (±1.65 ms) 12.05 (±1.45 ms) -0.3ms (2.8%) 👌
tablecmp-create-10k metric base(0ec65ea) target(b6cd416) trend
benchmark-table-component/create/10k duration 1787.00 (±22.80 ms) 1726.70 (±9.10 ms) -60.3ms (3.4%) 👍
tablecmp-create-1k metric base(0ec65ea) target(b6cd416) trend
benchmark-table-component/create/1k duration 215.30 (±4.35 ms) 208.55 (±6.90 ms) -6.8ms (3.1%) 👍
tablecmp-update-10th-1k metric base(0ec65ea) target(b6cd416) trend
benchmark-table-component/update-10th/1k duration 70.15 (±5.25 ms) 71.90 (±5.65 ms) +1.8ms (2.5%) 👌
wc-append-1k metric base(0ec65ea) target(b6cd416) trend
benchmark-table-wc/append/1k duration 260.60 (±5.40 ms) 250.30 (±6.40 ms) -10.3ms (4.0%) 👍
wc-clear-1k metric base(0ec65ea) target(b6cd416) trend
benchmark-table-wc/clear/1k duration 23.00 (±1.75 ms) 22.25 (±2.35 ms) -0.8ms (3.3%) 👌
wc-create-10k metric base(0ec65ea) target(b6cd416) trend
benchmark-table-wc/create/10k duration 1963.65 (±16.35 ms) 1925.00 (±15.05 ms) -38.7ms (2.0%) 👍
wc-create-1k metric base(0ec65ea) target(b6cd416) trend
benchmark-table-wc/create/1k duration 226.05 (±5.65 ms) 222.15 (±4.60 ms) -3.9ms (1.7%) 👍
wc-update-10th-1k metric base(0ec65ea) target(b6cd416) trend
benchmark-table-wc/update-10th/1k duration 71.10 (±5.85 ms) 71.10 (±5.75 ms) 0.0ms (0.0%) 👌

@caridy
Copy link
Collaborator Author

caridy commented Jan 18, 2019

confirmed that compat issues were flapper by running the job again which returns new failures... merging.

@caridy caridy merged commit 2caa4a2 into 218/patch Jan 18, 2019
@caridy caridy deleted the caridy/218-patch/cloneNode-issue-973 branch January 18, 2019 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ekashida ekashida ekashida approved these changes

@ravijayaramappa ravijayaramappa Awaiting requested review from ravijayaramappa

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
218
Development

Successfully merging this pull request may close these issues.
2 participants
@caridy @ekashida