Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(compiler): allow multiple @wire for different properties or methods #72

Merged
merged 1 commit into from
Feb 6, 2018

Conversation

yungcheng
Copy link
Contributor

Details

We have a bug that would prevent you to have more than one @wire in a LWC class.

Does this PR introduce a breaking change?

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:
Please check if your PR fulfills the following requirements:

@yungcheng yungcheng requested a review from pmdartus February 6, 2018 23:11
@salesforce-best-lwc-internal
Copy link

Benchmark comparison

Base commit: 1c05721 | Target commit: c844916

benchmark base(1c05721) target(c844916) trend
clear-1k.benchmark:benchmark-table/clear/1k 41.78 (± 0.95 ms) 15.72 (± 0.95 ms) 👍

@yungcheng yungcheng merged commit d9223fd into master Feb 6, 2018
@yungcheng yungcheng deleted the vince/wire-decorator-validation-fix branch February 6, 2018 23:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants