fix(engine): closes #486 to lowercase tag names

[caridy]

Details

Bug Fix Closes: #486

Does this PR introduce a breaking change?

• No

[salesforce-best-lwc-internal]

Benchmark results

Base commit: 575f881 | Target commit: 176a6ac

lwc-engine-benchmark

table-append-1k	metric	base(575f881)	target(176a6ac)	trend
benchmark-table/append/1k	duration	161.00 (± 5.40 ms)	151.80 (± 5.30 ms)	5.71% 👍

table-clear-1k	metric	base(575f881)	target(176a6ac)	trend
benchmark-table/clear/1k	duration	12.70 (± 0.60 ms)	12.20 (± 0.60 ms)	3.94% 👍

table-create-10k	metric	base(575f881)	target(176a6ac)	trend
benchmark-table/create/10k	duration	922.90 (± 8.30 ms)	902.70 (± 7.80 ms)	2.19% 👍

table-create-1k	metric	base(575f881)	target(176a6ac)	trend
benchmark-table/create/1k	duration	104.70 (± 2.40 ms)	102.95 (± 2.10 ms)	1.67% 👍

table-update-10th-1k	metric	base(575f881)	target(176a6ac)	trend
benchmark-table/update-10th/1k	duration	93.40 (± 4.20 ms)	87.40 (± 6.05 ms)	6.42% 👌

tablecmp-append-1k	metric	base(575f881)	target(176a6ac)	trend
benchmark-table-component/append/1k	duration	238.90 (± 5.30 ms)	235.30 (± 5.30 ms)	1.51% 👍

tablecmp-clear-1k	metric	base(575f881)	target(176a6ac)	trend
benchmark-table-component/clear/1k	duration	38.60 (± 2.20 ms)	36.50 (± 1.20 ms)	5.44% 👍

tablecmp-create-10k	metric	base(575f881)	target(176a6ac)	trend
benchmark-table-component/create/10k	duration	1601.30 (± 13.90 ms)	1614.60 (± 9.30 ms)	-0.83% 👎

tablecmp-create-1k	metric	base(575f881)	target(176a6ac)	trend
benchmark-table-component/create/1k	duration	179.15 (± 5.35 ms)	172.90 (± 3.70 ms)	3.49% 👍

tablecmp-update-10th-1k	metric	base(575f881)	target(176a6ac)	trend
benchmark-table-component/update-10th/1k	duration	78.20 (± 3.80 ms)	77.90 (± 3.60 ms)	0.38% 👌

wc-append-1k	metric	base(575f881)	target(176a6ac)	trend
benchmark-table-wc/append/1k	duration	275.70 (± 11.70 ms)	251.70 (± 17.70 ms)	8.71% 👍

wc-clear-1k	metric	base(575f881)	target(176a6ac)	trend
benchmark-table-wc/clear/1k	duration	39.50 (± 1.40 ms)	36.90 (± 1.80 ms)	6.58% 👍

wc-create-10k	metric	base(575f881)	target(176a6ac)	trend
benchmark-table-wc/create/10k	duration	2077.30 (± 9.90 ms)	2110.70 (± 8.80 ms)	-1.61% 👎

wc-create-1k	metric	base(575f881)	target(176a6ac)	trend
benchmark-table-wc/create/1k	duration	220.60 (± 4.10 ms)	220.00 (± 3.70 ms)	0.27% 👌

wc-update-10th-1k	metric	base(575f881)	target(176a6ac)	trend
benchmark-table-wc/update-10th/1k	duration	79.30 (± 5.30 ms)	78.80 (± 7.40 ms)	0.63% 👌

[ekashida]

Do we need to be concerned with l10n when dealing with tag names?

[caridy]

@ekashida good catch, autocomplete is killing me these days. Updated the code to use toLowerCase.

[salesforce-best-lwc-internal]

Benchmark results

Base commit: 9360827 | Target commit: fbdc3bf

lwc-engine-benchmark

table-append-1k	metric	base(9360827)	target(fbdc3bf)	trend
benchmark-table/append/1k	duration	149.30 (± 5.55 ms)	155.70 (± 5.90 ms)	-4.29% 👎

table-clear-1k	metric	base(9360827)	target(fbdc3bf)	trend
benchmark-table/clear/1k	duration	12.20 (± 0.60 ms)	12.40 (± 0.70 ms)	-1.64% 👌

table-create-10k	metric	base(9360827)	target(fbdc3bf)	trend
benchmark-table/create/10k	duration	894.80 (± 7.00 ms)	889.90 (± 11.20 ms)	0.55% 👌

table-create-1k	metric	base(9360827)	target(fbdc3bf)	trend
benchmark-table/create/1k	duration	104.00 (± 1.90 ms)	103.60 (± 1.90 ms)	0.38% 👌

table-update-10th-1k	metric	base(9360827)	target(fbdc3bf)	trend
benchmark-table/update-10th/1k	duration	86.60 (± 5.50 ms)	89.70 (± 4.70 ms)	-3.58% 👌

tablecmp-append-1k	metric	base(9360827)	target(fbdc3bf)	trend
benchmark-table-component/append/1k	duration	230.80 (± 4.40 ms)	235.00 (± 3.50 ms)	-1.82% 👎

tablecmp-clear-1k	metric	base(9360827)	target(fbdc3bf)	trend
benchmark-table-component/clear/1k	duration	37.50 (± 1.85 ms)	36.90 (± 1.20 ms)	1.60% 👌

tablecmp-create-10k	metric	base(9360827)	target(fbdc3bf)	trend
benchmark-table-component/create/10k	duration	1596.00 (± 7.60 ms)	1608.50 (± 13.10 ms)	-0.78% 👎

tablecmp-create-1k	metric	base(9360827)	target(fbdc3bf)	trend
benchmark-table-component/create/1k	duration	171.50 (± 4.70 ms)	175.10 (± 2.90 ms)	-2.10% 👎

tablecmp-update-10th-1k	metric	base(9360827)	target(fbdc3bf)	trend
benchmark-table-component/update-10th/1k	duration	78.30 (± 3.00 ms)	79.20 (± 3.10 ms)	-1.15% 👌

wc-append-1k	metric	base(9360827)	target(fbdc3bf)	trend
benchmark-table-wc/append/1k	duration	268.60 (± 15.20 ms)	269.70 (± 11.60 ms)	-0.41% 👌

wc-clear-1k	metric	base(9360827)	target(fbdc3bf)	trend
benchmark-table-wc/clear/1k	duration	37.70 (± 1.60 ms)	37.20 (± 0.70 ms)	1.33% 👌

wc-create-10k	metric	base(9360827)	target(fbdc3bf)	trend
benchmark-table-wc/create/10k	duration	2075.70 (± 10.80 ms)	2080.80 (± 10.30 ms)	-0.25% 👎

wc-create-1k	metric	base(9360827)	target(fbdc3bf)	trend
benchmark-table-wc/create/1k	duration	217.00 (± 4.30 ms)	216.00 (± 4.30 ms)	0.46% 👌

wc-update-10th-1k	metric	base(9360827)	target(fbdc3bf)	trend
benchmark-table-wc/update-10th/1k	duration	77.40 (± 5.60 ms)	79.30 (± 5.80 ms)	-2.45% 👌