Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Bump proxy-compat to 0.18.2 #288

Merged
merged 4 commits into from
May 9, 2018

Conversation

pmdartus
Copy link
Member

@pmdartus pmdartus commented May 8, 2018

Details

Update LWC dependency on proxy-compat version 0.18.2

Does this PR introduce a breaking change?

  • Yes
  • No

@pmdartus pmdartus requested a review from diervo May 8, 2018 20:58
@salesforce-best-lwc-internal
Copy link

Benchmark results

Base commit: a4509a9 | Target commit: 0f07a7e

lwc-engine-benchmark

table-append-1k metric base(a4509a9) target(0f07a7e) trend
benchmark-table/append/1k duration 153.20 (± 6.30 ms) 157.50 (± 5.45 ms) -2.81% 👎
table-clear-1k metric base(a4509a9) target(0f07a7e) trend
benchmark-table/clear/1k duration 12.45 (± 0.55 ms) 12.30 (± 0.50 ms) 1.20% 👌
table-create-10k metric base(a4509a9) target(0f07a7e) trend
benchmark-table/create/10k duration 880.30 (± 7.90 ms) 893.80 (± 16.10 ms) -1.53% 👎
table-create-1k metric base(a4509a9) target(0f07a7e) trend
benchmark-table/create/1k duration 102.10 (± 1.90 ms) 103.70 (± 2.40 ms) -1.57% 👎
table-update-10th-1k metric base(a4509a9) target(0f07a7e) trend
benchmark-table/update-10th/1k duration 92.70 (± 5.50 ms) 94.25 (± 4.10 ms) -1.67% 👌
tablecmp-append-1k metric base(a4509a9) target(0f07a7e) trend
benchmark-table-component/append/1k duration 245.50 (± 5.90 ms) 252.70 (± 4.50 ms) -2.93% 👎
tablecmp-clear-1k metric base(a4509a9) target(0f07a7e) trend
benchmark-table/clear/1k duration 31.25 (± 1.25 ms) 31.50 (± 2.05 ms) -0.80% 👌
tablecmp-create-10k metric base(a4509a9) target(0f07a7e) trend
benchmark-table-component/create/10k duration 1739.10 (± 7.00 ms) 1781.80 (± 9.50 ms) -2.46% 👎
tablecmp-create-1k metric base(a4509a9) target(0f07a7e) trend
benchmark-table-component/create/1k duration 196.90 (± 2.70 ms) 199.80 (± 2.90 ms) -1.47% 👎
tablecmp-update-10th-1k metric base(a4509a9) target(0f07a7e) trend
benchmark-table-component/update-10th/1k duration 76.00 (± 4.60 ms) 77.50 (± 4.70 ms) -1.97% 👌

@pmdartus pmdartus force-pushed the pmdartus/bump-proxy-compat-0.18.1 branch from 0f07a7e to 3ce5771 Compare May 9, 2018 00:10
@salesforce-best-lwc-internal
Copy link

Benchmark results

Base commit: a4509a9 | Target commit: 3ce5771

lwc-engine-benchmark

table-append-1k metric base(a4509a9) target(3ce5771) trend
benchmark-table/append/1k duration 153.20 (± 6.30 ms) 162.30 (± 5.10 ms) -5.94% 👎
table-clear-1k metric base(a4509a9) target(3ce5771) trend
benchmark-table/clear/1k duration 12.45 (± 0.55 ms) 12.50 (± 0.40 ms) -0.40% 👌
table-create-10k metric base(a4509a9) target(3ce5771) trend
benchmark-table/create/10k duration 880.30 (± 7.90 ms) 892.00 (± 5.80 ms) -1.33% 👎
table-create-1k metric base(a4509a9) target(3ce5771) trend
benchmark-table/create/1k duration 102.10 (± 1.90 ms) 103.80 (± 2.10 ms) -1.67% 👎
table-update-10th-1k metric base(a4509a9) target(3ce5771) trend
benchmark-table/update-10th/1k duration 92.70 (± 5.50 ms) 95.10 (± 3.80 ms) -2.59% 👌
tablecmp-append-1k metric base(a4509a9) target(3ce5771) trend
benchmark-table-component/append/1k duration 245.50 (± 5.90 ms) 257.50 (± 6.10 ms) -4.89% 👎
tablecmp-clear-1k metric base(a4509a9) target(3ce5771) trend
benchmark-table/clear/1k duration 31.25 (± 1.25 ms) 35.30 (± 1.70 ms) -12.96% 👎
tablecmp-create-10k metric base(a4509a9) target(3ce5771) trend
benchmark-table-component/create/10k duration 1739.10 (± 7.00 ms) 1791.10 (± 8.60 ms) -2.99% 👎
tablecmp-create-1k metric base(a4509a9) target(3ce5771) trend
benchmark-table-component/create/1k duration 196.90 (± 2.70 ms) 205.45 (± 2.75 ms) -4.34% 👎
tablecmp-update-10th-1k metric base(a4509a9) target(3ce5771) trend
benchmark-table-component/update-10th/1k duration 76.00 (± 4.60 ms) 76.10 (± 4.00 ms) -0.13% 👌

@pmdartus pmdartus merged commit c594e40 into master May 9, 2018
@pmdartus pmdartus deleted the pmdartus/bump-proxy-compat-0.18.1 branch May 9, 2018 15:27
@caridy
Copy link
Contributor

caridy commented May 9, 2018

@diervo did you get a chance to increase the runs in BEST? see the numbers here? 12% regression when this PR changes nothing that affects the perf.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants