refactor(aom): Fix ariaHasPopup and add ariaColSpan (#247) #253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* refactor(aom): Reorder alphabetically for easier maintenance * fix(aom): Add missing ariaColSpan prop https://github.com/w3c/aria/pull/708/files#diff-eacf331f0ffc35d4b482f1d15a887d3bR11051 * fix(aom): Use correct casing for ariaHasPopup https://github.com/w3c/aria/pull/708/files#diff-eacf331f0ffc35d4b482f1d15a887d3bR11060 * docs(aom): Add comments explaining how we arrived at this mapping (cherry picked from commit 405468a)
Benchmark comparisonBase commit:
|
pmdartus
approved these changes
Apr 13, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(cherry picked from commit 405468a)
Details
This PR might be difficult to review due to the reordering of props. It's probably easier to review by looking at the individual commits.
Correct casing for
ariaHasPopup:https://github.com/w3c/aria/pull/708/files#diff-eacf331f0ffc35d4b482f1d15a887d3bR11060
Add missing
ariaColSpanprop:https://github.com/w3c/aria/pull/708/files#diff-eacf331f0ffc35d4b482f1d15a887d3bR11051
Does this PR introduce a breaking change?
If yes, please describe the impact and migration path for existing applications:
Changing
ariaHasPopUptoariaHasPopupis technically a breaking change but I've confirmed that neither LGC nor core useariaHasPopUp/aria-haspopupin an LWC component.