fix(wire): remove WireContextEvent (camelcase) #1681
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caridy
reviewed
Jan 18, 2020
| @@ -253,7 +253,7 @@ export class WireEventTarget { | |||
| }); | |||
| this._cmp.dispatchEvent(internalDomEvent); | |||
| return false; // canceling signal since we don't want this to propagate | |||
| } else if (evt.type === 'WireContextEvent' || evt.type === 'wirecontextevent') { | |||
| } else if (evt.type === 'wirecontextevent') { | |||
There was a problem hiding this comment.
None that I found. It seems when the feature was implemented no tests were added.
There was a problem hiding this comment.
There was a problem hiding this comment.
Those tests exercise the v2 context mechanism: LinkContextEvent. I believe this WireContextEvent is the legacy v1 implementation which still has one consumer owned by @jbenallen .
caridy
approved these changes
Jan 20, 2020
jbenallen
approved these changes
Feb 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
Followup to #1679 to remove legacy
WireContextEvent. Usewirecontexteventinstead.Does this PR introduce breaking changes?
Yes, it does introduce breaking changes.Single consumer of
WireContextEventhas been updated to usewirecontexteventso no impact expected.