Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ci): set node version to 10.16.3 until #1597

Merged
merged 1 commit into from
Oct 29, 2019
Merged

fix(ci): set node version to 10.16.3 until #1597

merged 1 commit into from
Oct 29, 2019

Conversation

jodarove
Copy link
Contributor

10.17 is evaluated.

Details

Does this PR introduce breaking changes?

  • ✅ No, it does not introduce breaking changes.

@jodarove jodarove requested review from pmdartus and ekashida October 29, 2019 01:57
@jodarove
Copy link
Contributor Author

jodarove commented Oct 29, 2019 •
edited
Loading

we previously had node:10-browsers, and circleCI we just released node:10.17. We specify the node and yarn version in the package.json as:

"node": ">=10.16.3 <10.17.0",
"yarn": ">=1.17.3 <1.18.0"

@jodarove jodarove requested review from caridy and diervo October 29, 2019 01:59
@caridy
Copy link
Collaborator

caridy commented Oct 29, 2019

yes, I have the same issue yesterday with another PR.

@jodarove jodarove merged commit 8f57622 into master Oct 29, 2019
@jodarove jodarove deleted the jodarove/fix-ci-image branch October 29, 2019 02:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@caridy caridy caridy approved these changes

@pmdartus pmdartus Awaiting requested review from pmdartus

@ekashida ekashida Awaiting requested review from ekashida

@diervo diervo Awaiting requested review from diervo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jodarove @caridy