fix: guard usage of Array methods on nodelist and htmlcollection #1546
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ekashida
reviewed
Sep 30, 2019
There was a problem hiding this comment.
Thinking about this more, I think I would prefer an approach where we use Array.from or implement something similar to convert all of these collections into arrays before operating on them with array methods. We could then enforce this by adding assertions for all array methods so that they only operate on array instances. Thoughts?
|
Closing in favor of #1548 |
ravijayaramappa
deleted the
ravi/master/custom-collection-util/W-6684382
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
Legacy third party libraries that patch prototype of Array intrinsic are incapable of handling NodeList and HTMLCollection instances. For example, one such library is older version(1.7) of prototype.js
So this PR is to guard lwc engine against such legacy libraries by writing its own custom utils.
Fixes #1545
Does this PR introduce breaking changes?
No, it does not introduce breaking changes.If yes, please describe the impact and migration path for existing applications.
The PR fulfills these requirements: