fix: escape hatch for async event target accessor #1510
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When event's original target is from a non-keyed node, do not retarget event when accessed asynchronously
caridy
reviewed
Sep 17, 2019
| @@ -66,6 +67,10 @@ function targetGetter(this: Event): EventTarget | null { | |||
| // Handle cases where the currentTarget is null (for async events), | |||
| // and when an event has been added to Window | |||
| if (!(originalCurrentTarget instanceof Node)) { | |||
| // If the event's target is being accessed async and originalTarget is not a keyed element, do not retarget | |||
There was a problem hiding this comment.
we should add an issue to remove this in the future... with a TODO in the code.
There was a problem hiding this comment.
we should also do this in 222 too
There was a problem hiding this comment.
Filed #1511
caridy
approved these changes
Sep 17, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
When event's original target is from a non-keyed node, do not retarget event when accessed asynchronously
Does this PR introduce breaking changes?
No, it does not introduce breaking changes.If yes, please describe the impact and migration path for existing applications.
The PR fulfills these requirements: