Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: issue #1304 activeElement should be patched in the prototype #1321

Merged
merged 2 commits into from
May 31, 2019

Conversation

jodarove
Copy link
Contributor

Details

Addresses #1304

In the synthetic shadow we patch the activeElement on the document. this PR patch changes this behavior patching the activeElement in the Document.prototype

Does this PR introduce breaking changes?

  • No, it does not introduce breaking changes.

@jodarove jodarove requested review from davidturissini and caridy May 30, 2019 20:47
@jodarove
Copy link
Contributor Author

@davidturissini @caridy do you foresee any issue with this change?

@@ -57,7 +57,7 @@ export default function apply() {

// Go until we reach to top of the LWC tree
// TODO: #1304 - this should be patched on Document.prototype instead
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove the comment and close the issue when you merge this.

Copy link
Contributor

@caridy caridy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

update the comment, and merge.

@salesforce-best-lwc-internal
Copy link

Benchmark results

Base commit: 55b962b | Target commit: 49faecd

lwc-engine-benchmark

table-append-1k metric base(55b962b) target(49faecd) trend
benchmark-table/append/1k duration 142.75 (±4.35 ms) 137.60 (±4.05 ms) -5.2ms (3.6%) 👍
table-clear-1k metric base(55b962b) target(49faecd) trend
benchmark-table/clear/1k duration 10.40 (±0.90 ms) 11.10 (±1.00 ms) +0.7ms (6.7%) 👎
table-create-10k metric base(55b962b) target(49faecd) trend
benchmark-table/create/10k duration 846.85 (±5.40 ms) 848.00 (±6.10 ms) +1.1ms (0.1%) 👌
table-create-1k metric base(55b962b) target(49faecd) trend
benchmark-table/create/1k duration 108.65 (±3.05 ms) 107.75 (±1.85 ms) -0.9ms (0.8%) 👌
table-update-10th-1k metric base(55b962b) target(49faecd) trend
benchmark-table/update-10th/1k duration 69.90 (±3.75 ms) 77.10 (±3.70 ms) +7.2ms (10.3%) 👎
tablecmp-append-1k metric base(55b962b) target(49faecd) trend
benchmark-table-component/append/1k duration 211.15 (±16.90 ms) 225.85 (±10.10 ms) +14.7ms (7.0%) 👎
tablecmp-clear-1k metric base(55b962b) target(49faecd) trend
benchmark-table-component/clear/1k duration 6.90 (±1.20 ms) 6.80 (±1.05 ms) -0.1ms (1.4%) 👌
tablecmp-create-10k metric base(55b962b) target(49faecd) trend
benchmark-table-component/create/10k duration 1614.20 (±13.20 ms) 1606.95 (±11.90 ms) -7.2ms (0.4%) 👍
tablecmp-create-1k metric base(55b962b) target(49faecd) trend
benchmark-table-component/create/1k duration 184.05 (±5.60 ms) 184.15 (±4.85 ms) +0.1ms (0.1%) 👌
tablecmp-update-10th-1k metric base(55b962b) target(49faecd) trend
benchmark-table-component/update-10th/1k duration 68.00 (±4.45 ms) 68.35 (±3.70 ms) +0.3ms (0.5%) 👌
wc-append-1k metric base(55b962b) target(49faecd) trend
benchmark-table-wc/append/1k duration 254.60 (±7.65 ms) 247.55 (±6.85 ms) -7.0ms (2.8%) 👍
wc-clear-1k metric base(55b962b) target(49faecd) trend
benchmark-table-wc/clear/1k duration 11.90 (±1.35 ms) 11.90 (±1.75 ms) 0.0ms (0.0%) 👌
wc-create-10k metric base(55b962b) target(49faecd) trend
benchmark-table-wc/create/10k duration 1929.90 (±12.50 ms) 1933.00 (±9.90 ms) +3.1ms (0.2%) 👌
wc-create-1k metric base(55b962b) target(49faecd) trend
benchmark-table-wc/create/1k duration 234.80 (±5.85 ms) 233.40 (±6.05 ms) -1.4ms (0.6%) 👌
wc-update-10th-1k metric base(55b962b) target(49faecd) trend
benchmark-table-wc/update-10th/1k duration 64.80 (±4.85 ms) 65.80 (±4.05 ms) +1.0ms (1.5%) 👌

@jodarove jodarove merged commit 504e27a into master May 31, 2019
@jodarove jodarove deleted the jodarove/activeElement-in-prototype branch May 31, 2019 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants