feat: CSS only modules #1211
Merged
feat: CSS only modules #1211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Benchmark resultsBase commit: lwc-engine-benchmark
|
Benchmark resultsBase commit: lwc-engine-benchmark
|
caridy
reviewed
May 8, 2019
| @@ -14,7 +14,7 @@ const EMPTY_IMPLICIT_CSS_CONTENT = ''; | |||
| const EMPTY_IMPLICIT_HTML_CONTENT = 'export default void 0'; | |||
| const IMPLICIT_DEFAULT_HTML_PATH = '@lwc/resources/empty_html.js'; | |||
| const IMPLICIT_DEFAULT_CSS_PATH = '@lwc/resources/empty_css.css'; | |||
| const VALID_EXTENSIONS = ['.js', '.ts']; | |||
| const VALID_EXTENSIONS = ['.js', '.ts', '.html', '.css']; | |||
caridy
reviewed
May 8, 2019
| @@ -106,6 +99,16 @@ export function applyStyleAttributes(vm: VM, hostAttribute: string, shadowAttrib | |||
| context.shadowAttribute = shadowAttribute; | |||
| } | |||
|
|
|||
| function collectStylesheets(stylesheets, hostSelector, shadowSelector, isNative, fn) { | |||
There was a problem hiding this comment.
call fn -> aggregatorFn or something more specific
also add some notes to explain the why
caridy
reviewed
May 8, 2019
| @@ -13,7 +13,7 @@ import nodeModulePaths from './node-modules-paths'; | |||
|
|
|||
| const DEFAULT_IGNORE = ['**/node_modules/**', '**/__tests__/**']; | |||
| const PACKAGE_PATTERN = ['*/*/package.json', '*/package.json', 'package.json']; | |||
| const MODULE_ENTRY_PATTERN = `**/*.[jt]s`; | |||
| const MODULE_ENTRY_PATTERN = `**/*.([jt]s|html|css)`; | |||
|
Preparing for the html only :)
…On Tue, May 7, 2019 at 10:36 PM Caridy Patiño ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In ***@***.***/module-resolver/src/index.ts
<#1211 (comment)>:
> @@ -13,7 +13,7 @@ import nodeModulePaths from './node-modules-paths';
const DEFAULT_IGNORE = ['**/node_modules/**', '**/__tests__/**'];
const PACKAGE_PATTERN = ['*/*/package.json', '*/package.json', 'package.json'];
-const MODULE_ENTRY_PATTERN = `**/*.[jt]s`;
+const MODULE_ENTRY_PATTERN = `**/*.([jt]s|html|css)`;
html?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#1211 (review)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAI7JKAEFZ6GB5W3MEQOTQ3PUI4EBANCNFSM4HLK7DNQ>
.
|
|
The flapper can be ignored: |
|
ops, closed accidentally, diego will reopen it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
This PRs allow to define CSS only modules.