Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: optimize module resolution #1183

Merged
merged 1 commit into from
Apr 19, 2019
Merged

Conversation

diervo
Copy link
Contributor

@diervo diervo commented Apr 18, 2019

For LWC we went from 8 seconds to 500ms. Still room for improvement.
Fixes #1162 (at least partially)

@diervo diervo requested review from pmdartus and trevor-bliss April 18, 2019 18:01
@salesforce-best-lwc-internal
Copy link

Benchmark results

Base commit: 0168622 | Target commit: ccfed78

lwc-engine-benchmark

table-append-1k metric base(0168622) target(ccfed78) trend
benchmark-table/append/1k duration 152.70 (±3.30 ms) 156.60 (±4.95 ms) +3.9ms (2.6%) 👎
table-clear-1k metric base(0168622) target(ccfed78) trend
benchmark-table/clear/1k duration 11.10 (±0.70 ms) 11.00 (±0.60 ms) -0.1ms (0.9%) 👌
table-create-10k metric base(0168622) target(ccfed78) trend
benchmark-table/create/10k duration 881.00 (±6.65 ms) 879.25 (±8.90 ms) -1.8ms (0.2%) 👌
table-create-1k metric base(0168622) target(ccfed78) trend
benchmark-table/create/1k duration 118.10 (±2.70 ms) 120.20 (±2.85 ms) +2.1ms (1.8%) 👎
table-update-10th-1k metric base(0168622) target(ccfed78) trend
benchmark-table/update-10th/1k duration 74.25 (±5.50 ms) 71.50 (±4.20 ms) -2.8ms (3.7%) 👌
tablecmp-append-1k metric base(0168622) target(ccfed78) trend
benchmark-table-component/append/1k duration 227.05 (±9.40 ms) 226.95 (±10.80 ms) -0.1ms (0.0%) 👌
tablecmp-clear-1k metric base(0168622) target(ccfed78) trend
benchmark-table-component/clear/1k duration 6.35 (±1.05 ms) 6.30 (±1.00 ms) -0.0ms (0.8%) 👌
tablecmp-create-10k metric base(0168622) target(ccfed78) trend
benchmark-table-component/create/10k duration 1735.95 (±21.05 ms) 1714.95 (±10.25 ms) -21.0ms (1.2%) 👍
tablecmp-create-1k metric base(0168622) target(ccfed78) trend
benchmark-table-component/create/1k duration 209.60 (±5.70 ms) 207.45 (±6.10 ms) -2.2ms (1.0%) 👌
tablecmp-update-10th-1k metric base(0168622) target(ccfed78) trend
benchmark-table-component/update-10th/1k duration 68.00 (±4.65 ms) 70.20 (±5.30 ms) +2.2ms (3.2%) 👌
wc-append-1k metric base(0168622) target(ccfed78) trend
benchmark-table-wc/append/1k duration 229.70 (±18.35 ms) 233.60 (±17.20 ms) +3.9ms (1.7%) 👌
wc-clear-1k metric base(0168622) target(ccfed78) trend
benchmark-table-wc/clear/1k duration 10.70 (±1.65 ms) 10.65 (±1.80 ms) -0.0ms (0.5%) 👌
wc-create-10k metric base(0168622) target(ccfed78) trend
benchmark-table-wc/create/10k duration 1852.30 (±26.65 ms) 1870.20 (±19.55 ms) +17.9ms (1.0%) 👎
wc-create-1k metric base(0168622) target(ccfed78) trend
benchmark-table-wc/create/1k duration 216.90 (±7.45 ms) 217.65 (±4.80 ms) +0.8ms (0.3%) 👌
wc-update-10th-1k metric base(0168622) target(ccfed78) trend
benchmark-table-wc/update-10th/1k duration 67.75 (±4.80 ms) 69.40 (±4.65 ms) +1.7ms (2.4%) 👌

@salesforce-best-lwc-internal
Copy link

Benchmark results

Base commit: 0168622 | Target commit: ccfed78

lwc-engine-benchmark

table-append-1k metric base(0168622) target(ccfed78) trend
benchmark-table/append/1k duration 152.70 (±3.30 ms) 154.15 (±2.70 ms) +1.4ms (0.9%) 👌
table-clear-1k metric base(0168622) target(ccfed78) trend
benchmark-table/clear/1k duration 11.10 (±0.70 ms) 10.70 (±0.60 ms) -0.4ms (3.6%) 👌
table-create-10k metric base(0168622) target(ccfed78) trend
benchmark-table/create/10k duration 881.00 (±6.65 ms) 886.75 (±7.00 ms) +5.8ms (0.7%) 👎
table-create-1k metric base(0168622) target(ccfed78) trend
benchmark-table/create/1k duration 118.10 (±2.70 ms) 116.95 (±2.45 ms) -1.1ms (1.0%) 👌
table-update-10th-1k metric base(0168622) target(ccfed78) trend
benchmark-table/update-10th/1k duration 74.25 (±5.50 ms) 70.85 (±1.85 ms) -3.4ms (4.6%) 👍
tablecmp-append-1k metric base(0168622) target(ccfed78) trend
benchmark-table-component/append/1k duration 227.05 (±9.40 ms) 228.55 (±9.85 ms) +1.5ms (0.7%) 👌
tablecmp-clear-1k metric base(0168622) target(ccfed78) trend
benchmark-table-component/clear/1k duration 6.35 (±1.05 ms) 6.85 (±1.25 ms) +0.5ms (7.9%) 👌
tablecmp-create-10k metric base(0168622) target(ccfed78) trend
benchmark-table-component/create/10k duration 1735.95 (±21.05 ms) 1737.90 (±15.80 ms) +2.0ms (0.1%) 👌
tablecmp-create-1k metric base(0168622) target(ccfed78) trend
benchmark-table-component/create/1k duration 209.60 (±5.70 ms) 210.05 (±6.20 ms) +0.5ms (0.2%) 👌
tablecmp-update-10th-1k metric base(0168622) target(ccfed78) trend
benchmark-table-component/update-10th/1k duration 68.00 (±4.65 ms) 68.10 (±4.60 ms) +0.1ms (0.1%) 👌
wc-append-1k metric base(0168622) target(ccfed78) trend
benchmark-table-wc/append/1k duration 229.70 (±18.35 ms) 232.35 (±18.20 ms) +2.7ms (1.2%) 👌
wc-clear-1k metric base(0168622) target(ccfed78) trend
benchmark-table-wc/clear/1k duration 10.70 (±1.65 ms) 11.50 (±1.35 ms) +0.8ms (7.5%) 👌
wc-create-10k metric base(0168622) target(ccfed78) trend
benchmark-table-wc/create/10k duration 1852.30 (±26.65 ms) 1867.20 (±17.70 ms) +14.9ms (0.8%) 👎
wc-create-1k metric base(0168622) target(ccfed78) trend
benchmark-table-wc/create/1k duration 216.90 (±7.45 ms) 216.50 (±4.65 ms) -0.4ms (0.2%) 👌
wc-update-10th-1k metric base(0168622) target(ccfed78) trend
benchmark-table-wc/update-10th/1k duration 67.75 (±4.80 ms) 68.15 (±5.50 ms) +0.4ms (0.6%) 👌

@diervo
Copy link
Contributor Author

diervo commented Apr 19, 2019

Fixes #1162

@diervo diervo merged commit 81ffabf into master Apr 19, 2019
@diervo diervo deleted the dval/resolutionOptimization branch April 19, 2019 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[rollup-plugin] Cache npm modules after first rollup execution
2 participants