Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove comments in minified bundle @W-5320429 #599

Merged
merged 2 commits into from
Aug 18, 2018

Conversation

apapko
Copy link
Collaborator

@apapko apapko commented Aug 17, 2018

Details

Add babel configuration

comments: false 

into the minified configuration

Does this PR introduce a breaking change?

  • Yes
  • No

@apapko apapko requested a review from pmdartus August 17, 2018 18:23
@apapko apapko changed the title fix: remove comments in minified bundled @W-5356134 fix: remove comments in minified bundled @W-5320429 Aug 17, 2018
@salesforce-best-lwc-internal
Copy link

Benchmark results

Base commit: 38fe207 | Target commit: b41d283

lwc-engine-benchmark

table-append-1k metric base(38fe207) target(b41d283) trend
benchmark-table/append/1k duration 159.80 (± 5.40 ms) 157.70 (± 3.40 ms) 1.31% 👍
table-clear-1k metric base(38fe207) target(b41d283) trend
benchmark-table/clear/1k duration 12.20 (± 0.50 ms) 11.80 (± 0.60 ms) 3.28% 👍
table-create-10k metric base(38fe207) target(b41d283) trend
benchmark-table/create/10k duration 904.50 (± 6.20 ms) 921.40 (± 5.90 ms) -1.87% 👎
table-create-1k metric base(38fe207) target(b41d283) trend
benchmark-table/create/1k duration 108.20 (± 1.70 ms) 107.00 (± 1.60 ms) 1.11% 👍
table-update-10th-1k metric base(38fe207) target(b41d283) trend
benchmark-table/update-10th/1k duration 92.90 (± 5.80 ms) 95.40 (± 4.00 ms) -2.69% 👌
tablecmp-append-1k metric base(38fe207) target(b41d283) trend
benchmark-table-component/append/1k duration 238.60 (± 6.70 ms) 239.60 (± 5.50 ms) -0.42% 👌
tablecmp-clear-1k metric base(38fe207) target(b41d283) trend
benchmark-table-component/clear/1k duration 34.95 (± 2.25 ms) 36.20 (± 1.80 ms) -3.58% 👌
tablecmp-create-10k metric base(38fe207) target(b41d283) trend
benchmark-table-component/create/10k duration 1623.40 (± 9.10 ms) 1658.00 (± 12.50 ms) -2.13% 👎
tablecmp-create-1k metric base(38fe207) target(b41d283) trend
benchmark-table-component/create/1k duration 176.80 (± 3.70 ms) 180.70 (± 3.30 ms) -2.21% 👎
tablecmp-update-10th-1k metric base(38fe207) target(b41d283) trend
benchmark-table-component/update-10th/1k duration 79.50 (± 3.70 ms) 80.40 (± 4.20 ms) -1.13% 👌
wc-append-1k metric base(38fe207) target(b41d283) trend
benchmark-table-wc/append/1k duration 274.30 (± 8.30 ms) 257.30 (± 13.40 ms) 6.20% 👍
wc-clear-1k metric base(38fe207) target(b41d283) trend
benchmark-table-wc/clear/1k duration 35.30 (± 1.30 ms) 37.40 (± 1.50 ms) -5.95% 👎
wc-create-10k metric base(38fe207) target(b41d283) trend
benchmark-table-wc/create/10k duration 2114.20 (± 9.70 ms) 2100.00 (± 11.70 ms) 0.67% 👍
wc-create-1k metric base(38fe207) target(b41d283) trend
benchmark-table-wc/create/1k duration 225.00 (± 5.00 ms) 218.20 (± 3.10 ms) 3.02% 👍
wc-update-10th-1k metric base(38fe207) target(b41d283) trend
benchmark-table-wc/update-10th/1k duration 80.20 (± 2.90 ms) 80.20 (± 3.60 ms) 0.00% 👌

@apapko apapko changed the title fix: remove comments in minified bundled @W-5320429 fix: remove comments in minified bundle @W-5320429 Aug 17, 2018
@apapko apapko changed the base branch from master to 216/patch August 17, 2018 22:17
@apapko apapko changed the base branch from 216/patch to master August 17, 2018 22:39
@diervo diervo merged commit 46d65c0 into master Aug 18, 2018
@diervo diervo deleted the apapko/strip-comment-in-minify branch August 18, 2018 16:40
@nrobertdehault
Copy link
Contributor

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants