fix: remove comments in minified bundle @W-5320429 (#599)

## Details Add babel configuration ```js comments: false ``` into the minified configuration ## Does this PR introduce a breaking change? * [ ] Yes * [X] No
salesforce · Aug 18, 2018 · 46d65c0 · 46d65c0
1 parent 38fe207
commit 46d65c0
Show file tree

Hide file tree

Showing 17 changed files with 150 additions and 307 deletions.
diff --git a/packages/lwc-compiler/src/__tests__/fixtures/comments/comments.css b/packages/lwc-compiler/src/__tests__/fixtures/comments/comments.css
@@ -0,0 +1,9 @@
+:host {
+    color: blue;
+}
+
+/* css comment */
+
+x-comments {
+    color: green;
+}
diff --git a/packages/lwc-compiler/src/__tests__/fixtures/comments/comments.html b/packages/lwc-compiler/src/__tests__/fixtures/comments/comments.html
@@ -0,0 +1,4 @@
+<template>
+    <!-- html comment -->
+    <h1>{myname}</h1>
+</template>
diff --git a/packages/lwc-compiler/src/__tests__/fixtures/comments/comments.js b/packages/lwc-compiler/src/__tests__/fixtures/comments/comments.js
@@ -0,0 +1,7 @@
+import { LightningElement, track } from 'lwc';
+
+export default class Comments extends LightningElement {
+    // javascript comment
+    @track
+    myname = 'default value';
+}
diff --git a/packages/lwc-compiler/src/__tests__/fixtures/expected-all-modes.js b/packages/lwc-compiler/src/__tests__/fixtures/expected-all-modes.js
diff --git a/packages/lwc-compiler/src/__tests__/fixtures/expected-compat-mode.js b/packages/lwc-compiler/src/__tests__/fixtures/expected-compat-mode.js
diff --git a/packages/lwc-compiler/src/__tests__/fixtures/expected-compile-individual-resources.js b/packages/lwc-compiler/src/__tests__/fixtures/expected-compile-individual-resources.js
diff --git a/...compiler/src/__tests__/fixtures/expected-compile-with-no-options-and-default-namespace.js b/...compiler/src/__tests__/fixtures/expected-compile-with-no-options-and-default-namespace.js
diff --git a/packages/lwc-compiler/src/__tests__/fixtures/expected-external-dependency.js b/packages/lwc-compiler/src/__tests__/fixtures/expected-external-dependency.js
diff --git a/packages/lwc-compiler/src/__tests__/fixtures/expected-mapping-namespace-from-path.js b/packages/lwc-compiler/src/__tests__/fixtures/expected-mapping-namespace-from-path.js
diff --git a/packages/lwc-compiler/src/__tests__/fixtures/expected-minify-no-comments.js b/packages/lwc-compiler/src/__tests__/fixtures/expected-minify-no-comments.js
diff --git a/packages/lwc-compiler/src/__tests__/fixtures/expected-prod-mode.js b/packages/lwc-compiler/src/__tests__/fixtures/expected-prod-mode.js
@@ -1 +1 @@
-define("x-class_and_template",["lwc"],function(a){function b(a){const{h:b}=a;return[b("section",{key:1},[])]}class c extends a.Element{constructor(){super(),this.t=1,this.counter=0}render(){return b}}return c.style=b.style,c});
+define("x-class_and_template",["lwc"],function(a){function b(a){const{h:b}=a;return[b("section",{key:1},[])]}class c extends a.LightningElement{constructor(){super(),this.t=1,this.counter=0}render(){return b}}return c});
diff --git a/packages/lwc-compiler/src/__tests__/fixtures/expected-prod_compat-mode.js b/packages/lwc-compiler/src/__tests__/fixtures/expected-prod_compat-mode.js
diff --git a/packages/lwc-compiler/src/__tests__/fixtures/expected-relative-import.js b/packages/lwc-compiler/src/__tests__/fixtures/expected-relative-import.js
diff --git a/packages/lwc-compiler/src/__tests__/fixtures/expected-sources-namespaced-format.js b/packages/lwc-compiler/src/__tests__/fixtures/expected-sources-namespaced-format.js
diff --git a/packages/lwc-compiler/src/__tests__/fixtures/expected-sources-namespaced.js b/packages/lwc-compiler/src/__tests__/fixtures/expected-sources-namespaced.js
Original file line number	Diff line number	Diff line change
		@@ -1 +1 @@
		define("x-class_and_template",["lwc"],function(a){function b(a){const{h:b}=a;return[b("section",{key:1},[])]}class c extends a.Element{constructor(){super(),this.t=1,this.counter=0}render(){return b}}return c.style=b.style,c});
		define("x-class_and_template",["lwc"],function(a){function b(a){const{h:b}=a;return[b("section",{key:1},[])]}class c extends a.LightningElement{constructor(){super(),this.t=1,this.counter=0}render(){return b}}return c});