fix(wire): add lowercase wirecontextevent #1679
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
additionally, since this is only going to be use by 2 modules, we can just go with the lower case, and change it there too and completely remove the CamelCase value from the code. |
caridy
reviewed
Jan 16, 2020
| @@ -253,7 +253,7 @@ export class WireEventTarget { | |||
| }); | |||
| this._cmp.dispatchEvent(internalDomEvent); | |||
| return false; // canceling signal since we don't want this to propagate | |||
| } else if (evt.type === 'WireContextEvent') { | |||
| } else if (evt.type === 'WireContextEvent' || evt.type === 'wirecontextevent') { | |||
There was a problem hiding this comment.
we should probably update the tests for this too to use the lowercase.
|
I plan to issue a subsequent PR to remove I'll add a test for |
caridy
approved these changes
Jan 17, 2020
jbenallen
approved these changes
Jan 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
Accept
wirecontexteventto avoid engine warnings about event names.WireContextEventcan be removed after all consumers are updated towirecontextevent.Does this PR introduce breaking changes?
No, it does not introduce breaking changes.