Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[engine] refactor unit tests into karma integration tests #1295

Closed
ekashida opened this issue May 28, 2019 · 4 comments
Closed

[engine] refactor unit tests into karma integration tests #1295

ekashida opened this issue May 28, 2019 · 4 comments
Labels
USER STORY

Comments

@ekashida
Copy link
Member

Many of our unit tests are sensitive to compiler changes because they rely on non-public APIs. They should be refactored to only use public APIs.
caridy added a commit that referenced this issue Aug 3, 2019
@caridy
fix(engine): #1295 - removing hack to support old metadata in tests
169c2a9
caridy added a commit that referenced this issue Aug 5, 2019
@caridy
fix(engine): #1295 - removing hack to support old metadata in tests (#…
a40d174 
…1436)

* fix(engine): #1295 - removing hack to support old metadata in tests
@ekashida
Copy link
Member Author

@ravijayaramappa can you confirm this is no longer the case?

@ekashida
Copy link
Member Author

Discussed with @ravijayaramappa and we agreed this should stay open until we refactor all tests that use compileTemplate.

@git2gus
Copy link

git2gus bot commented Feb 28, 2020

This issue has been linked to a new work item: W-7273573

@ravijayaramappa
Copy link
Contributor

We no longer have tests that use compileTemplate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
USER STORY
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ekashida @ravijayaramappa @pmdartus