Remove dangerousObjectMutation from engine

[davidturissini]

Description

We recently added dangerousObjectMutation method on the engine for component authors to opt-out of read-only membrane in public props. This method is designed to be a temporary stop-gap, and should be removed ASAP.

[caridy]

Do we need to wait until we remove the traverse membrane to be able to remove this? or should we be able to remove this now?

[davidturissini]

This was added for observable-membrane and was designed to be an escape hatch for lightning-data-table if I believe. I'm not sure we can remove this yet.

[caridy]

cc @gonzalocordero @jodarove @reiniergs, can any of you confirm?

[jodarove]

we use it in two places:

1- modules/lightning/datatable/columns
2- modules/lightning/primitive-datatable-tooltip/primitive-datatable-tooltip

I can get why we use it in (1) (and as we speak we plan to remove it). but i don't know why we should use it in (2)

@davidturissini do you have any idea why the second usage?

[davidturissini]

@jodarove You can definitely remove from primitive-datatable-tooltip. I looked at datatable/columns and that component will need to be refactored.

[pmdartus]

I don't see any code that is referencing this API anymore in the global components. Is there any other blocker with removing this API?

[diervo]

O yes it is used.... but I agree we should kill it before GA

…

On Tue, Nov 13, 2018 at 4:54 AM Pierre-Marie Dartus < ***@***.***> wrote: I don't see any code that is referencing this API anymore in the global components. Is there any other blocker with removing this API? — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#129 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABH0qOqSzLtaGaqptE4xqVcHkxTsoRo-ks5uusEQgaJpZM4SYzye> .

[caridy]

let's remove it.

[diervo]

I'm hearing that @caridy is volunteering to remove occurrences in core! 🎉

[caridy]

there you go diego: #831

now we just need to wait 2 weeks to get this merged 🤣

[pmdartus]

Fixed by #831