fix(engine): issue #988 ShadowRoot unknown properties (#999)

salesforce · Jan 24, 2019 · fbfa0b5 · fbfa0b5
1 parent 735e8ea
commit fbfa0b5
Show file tree

Hide file tree

Showing 2 changed files with 0 additions and 40 deletions.
diff --git a/packages/@lwc/engine/src/faux-shadow/__tests__/shadow-root.spec.ts b/packages/@lwc/engine/src/faux-shadow/__tests__/shadow-root.spec.ts
@@ -489,13 +489,8 @@ describe('root', () => {
             expect(shadowRoot.nodeType).toBe(Node.DOCUMENT_FRAGMENT_NODE);
             expect(shadowRoot.nodeName).toBe('#document-fragment');
             expect(shadowRoot.nodeValue).toBe(null);
-            expect(shadowRoot.namespaceURI).toBe(null);
             expect(shadowRoot.nextSibling).toBe(null);
             expect(shadowRoot.previousSibling).toBe(null);
-            expect(shadowRoot.nextElementSibling).toBe(null);
-            expect(shadowRoot.previousElementSibling).toBe(null);
-            expect(shadowRoot.localName).toBe(null);
-            expect(shadowRoot.prefix).toBe(null);
             expect(shadowRoot.ownerDocument).toBe(elem.ownerDocument);
             expect(shadowRoot.baseURI).toBe(elem.baseURI);
             expect(shadowRoot.isConnected).toBe(true);

diff --git a/packages/@lwc/engine/src/faux-shadow/shadow-root.ts b/packages/@lwc/engine/src/faux-shadow/shadow-root.ts
@@ -393,41 +393,6 @@ const ElementPatchDescriptors = {
             return innerHTML;
         },
     },
-    localName: {
-        enumerable: true,
-        configurable: true,
-        get() {
-            return null;
-        },
-    },
-    namespaceURI: {
-        enumerable: true,
-        configurable: true,
-        get() {
-            return null;
-        },
-    },
-    nextElementSibling: {
-        enumerable: true,
-        configurable: true,
-        get() {
-            return null;
-        },
-    },
-    previousElementSibling: {
-        enumerable: true,
-        configurable: true,
-        get() {
-            return null;
-        },
-    },
-    prefix: {
-        enumerable: true,
-        configurable: true,
-        get() {
-            return null;
-        },
-    },
 };
 
 const ParentNodePatchDescriptors = {