refactor: relax url validation for href attribute

salesforce · May 1, 2019 · f0484df · f0484df
1 parent 8b29f4e
commit f0484df
Showing 1 changed file with 6 additions and 4 deletions.
diff --git a/packages/@lwc/engine/src/framework/api.ts b/packages/@lwc/engine/src/framework/api.ts
@@ -674,10 +674,12 @@ export function gid(id: string | undefined | null): string | null | undefined {
 export function fid(url: string | undefined | null): string | null | undefined {
     if (isUndefined(url) || url === '') {
         if (process.env.NODE_ENV !== 'production') {
-            assert.logError(
-                `Invalid url value "${url}". Expected a non-empty string.`,
-                vmBeingRendered!.elm
-            );
+            if (isUndefined(url)) {
+                assert.logError(
+                    `Undefined url value for "href" or "xlink:href" attribute. Expected a non-empty string.`,
+                    vmBeingRendered!.elm
+                );
+            }
         }
         return url;
     }