fix(compiler): Allow data to be a valid prop name (#7)

* Allowing data to be a valid propname * using length instead of string equality check
salesforce · Jan 17, 2018 · b5a7efd · b5a7efd
1 parent ef42218
commit b5a7efd
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 1 deletion.
diff --git a/packages/babel-plugin-transform-lwc-class/src/__tests__/api-decorator.test.js b/packages/babel-plugin-transform-lwc-class/src/__tests__/api-decorator.test.js
@@ -234,6 +234,19 @@ describe('Public Props', () => {
         }
     });
 
+    test('does not throw error if property name is "data"', `
+        export default class Test {
+            @api data;
+        }
+    `, `
+        export default class Test {}
+        Test.publicProps = {
+            data: {
+                config: 0
+            }
+        };
+    `);
+
     test('throws error if property name prefixed with "data"', `
         export default class Test {
             @api dataFooBar;

diff --git a/packages/babel-plugin-transform-lwc-class/src/decorators/api.js b/packages/babel-plugin-transform-lwc-class/src/decorators/api.js
@@ -87,7 +87,7 @@ function validatePropertyName(property) {
         throw property.buildCodeFrameError(
             `Invalid property name ${propertyName}. Properties starting with "on" are reserved for event handlers.`
         );
-    } else if (propertyName.startsWith('data')) {
+    } else if (propertyName.startsWith('data') && propertyName.length > 4) {
         throw property.buildCodeFrameError(
             `Invalid property name ${propertyName}. Properties starting with "data" are reserved attributes.`
         );