Skip to content

Commit

Permalink
fix: tf because registerDecorators happens before registerAdapter
Browse files Browse the repository at this point in the history
  • Loading branch information
jodarove committed Sep 25, 2019
1 parent f7babf3 commit b2d1a89
Show file tree
Hide file tree
Showing 3 changed files with 10 additions and 9 deletions.
13 changes: 8 additions & 5 deletions packages/@lwc/engine/src/framework/wiring.ts
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,14 @@ function createContextWatcher(
}

function createConnector(vm: VM, name: string, wireDef: WireDef): WireAdapter {
const { method, adapter } = wireDef;
const { method } = wireDef;
let adapter = wireDef.adapter;

// support for callable adapters
if ((adapter as any).adapter) {
adapter = (adapter as any).adapter;
}

const dataCallback = isUndefined(method)
? createFieldDataCallback(vm, name)
: createMethodDataCallback(vm, method);
Expand Down Expand Up @@ -200,10 +207,6 @@ export function storeWiredMethodMeta(
adapter: WireAdapterConstructor,
configCallback: ConfigCallback
) {
// support for callable adapters
if ((adapter as any).adapter) {
adapter = (adapter as any).adapter;
}
const method = descriptor.value;
const def: WireMethodDef = {
adapter,
Expand Down
4 changes: 1 addition & 3 deletions packages/integration-tests/src/shared/templates.js
Original file line number Diff line number Diff line change
Expand Up @@ -13,13 +13,11 @@ exports.app = function(cmpName) {

exports.todoApp = function(cmpName) {
return `
import { registerWireService, register as registerAdapter, ValueChangedEvent } from 'wire-service';
import { register as registerAdapter, ValueChangedEvent } from 'wire-service';
import { createElement, register } from 'lwc';
import Cmp from 'integration/${cmpName}';
import { getTodo, getObservable } from 'todo';
registerWireService(register);
// Register the wire adapter for @wire(getTodo).
registerAdapter(getTodo, function getTodoWireAdapter(wiredEventTarget) {
var subscription;
Expand Down
2 changes: 1 addition & 1 deletion packages/integration-tests/src/shared/todo.js
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@
return getSubject(todo).observable;
}

const getTodo = Symbol('getTodo');
const getTodo = function() {};

exports.getTodo = getTodo;
exports.getObservable = getObservable;
Expand Down

0 comments on commit b2d1a89

Please sign in to comment.