Skip to content

Commit

Permalink
perf: Update best (#257)
Browse files Browse the repository at this point in the history
* perf: Update best

* chore: Fix CI perf command
  • Loading branch information
diervo authored Apr 20, 2018
1 parent 5fd64c2 commit aca5593
Show file tree
Hide file tree
Showing 6 changed files with 312 additions and 103 deletions.
6 changes: 4 additions & 2 deletions .circleci/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -116,15 +116,17 @@ jobs:
- run: yarn install
- run:
name: Preformance Test
command: yarn test:performance
working_directory: packages/benchmark
command: yarn start --externalStorage=@best/store-aws --runner remote

- store_artifacts:
path: ~/lwc/packages/benchmark/__benchmark_results__/
destination: benchmarks

- run:
name: Comparing Benchmarks
command: cd packages/benchmark/ && yarn start --compareStats ${BASE_COMMIT} ${TARGET_COMMIT} --externalStorage=@best/store-aws --gitIntegration
working_directory: packages/benchmark
command: yarn start --compareStats ${BASE_COMMIT} ${TARGET_COMMIT} --externalStorage=@best/store-aws --gitIntegration


workflows:
Expand Down
17 changes: 10 additions & 7 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -5,14 +5,17 @@ dist/*.js
node_modules/
coverage/
.vscode/
.idea/
.project/

lib/
playground/*
playground/
packages/**/dist/
benchmarking/dist/
__benchmark_results__/
.idea/
.project/
packages/lwc-integration/public
packages/lwc-integration/errorShots
__benchmarks_results__/

packages/lwc-integration/public/
packages/lwc-integration/errorShots/
packages/lwc-integration/results/
packages/lwc-integration/.env
packages/lwc-integration/results

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
"types": "tsc --noEmit",
"test": "jest",
"test:integration": "yarn run build && lerna exec --scope lwc-integration -- yarn sauce",
"test:performance": "lerna exec --scope benchmark -- best --externalStorage='@best/store-aws'",
"test:performance": "lerna exec --scope benchmark -- best --runner remote",
"build": "lerna run build --ignore benchmark --ignore lwc-integration",
"build:artifacts": "npm run build && npm run build:compiler",
"build:compiler": "lerna exec --scope lwc-compiler yarn build:umd",
Expand Down
23 changes: 18 additions & 5 deletions packages/benchmark/best.config.js
Original file line number Diff line number Diff line change
@@ -1,11 +1,24 @@
module.exports = {
projectName: 'lwc-engine-benchmark',
plugins: {
'rollup-plugin-lwc-compiler': {
plugins: [
['rollup-plugin-lwc-compiler', {
rootDir: '<rootDir>/src/',
mode: 'prod',
},
},
}],
],
benchmarkOnClient: false,
benchmarkRunner: '@best/runner-headless',
runnerConfig: [
{
"runner": '@best/runner-headless',
"name": "default",
},
{
"runner": '@best/runner-remote',
"name": "remote",
"config": {
"host": "http://best-agent-pool.lwcjs.org",
"options": { path: '/best' },
"remoteRunner": "@best/runner-headless"
}
}],
};
7 changes: 4 additions & 3 deletions packages/benchmark/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,10 @@
"test": "echo 'No unit test in this package'"
},
"devDependencies": {
"@best/runner-headless": "0.0.13",
"@best/store-aws": "0.0.13",
"best-cli": "0.0.13"
"@best/runner-headless": "0.5.0",
"@best/runner-remote": "0.5.0",
"@best/store-aws": "0.5.0",
"best-cli": "0.5.0"
},
"dependencies": {
"lwc-engine": "0.19.0-0",
Expand Down
Loading

0 comments on commit aca5593

Please sign in to comment.