fix: disable shadow and membrane in prod (#372)

## Details Fixing shadowDOM implementation for selenium
salesforce · Jun 3, 2018 · 41149c2 · 41149c2
1 parent ff89fb7
commit 41149c2
Show file tree

Hide file tree

Showing 5 changed files with 14 additions and 23 deletions.
diff --git a/packages/lwc-engine/src/framework/dom/__tests__/shadow-root.spec.ts b/packages/lwc-engine/src/framework/dom/__tests__/shadow-root.spec.ts
@@ -8,7 +8,7 @@ import { Component } from "../../component";
 describe('root', () => {
     describe('integration', () => {
 
-        it('should support this.template.host', () => {
+        it.skip('should support this.template.host', () => {
             class MyComponent extends Element {}
             const elm = createElement('x-foo', { is: MyComponent });
             const vm = elm[ViewModelReflection] as VM;

diff --git a/packages/lwc-engine/src/framework/dom/__tests__/traverse.spec.ts b/packages/lwc-engine/src/framework/dom/__tests__/traverse.spec.ts
@@ -508,7 +508,7 @@ describe('#parentNode and #parentElement', () => {
         document.body.appendChild(elm);
         return Promise.resolve().then(() => {
             const root = elm.shadowRoot;
-            expect(root.querySelector('div').parentNode).toBe(root);
+            expect(root.querySelector('div').parentElement).toBe(root);
         });
     });
 

diff --git a/packages/lwc-engine/src/framework/dom/shadow-root.ts b/packages/lwc-engine/src/framework/dom/shadow-root.ts
@@ -156,16 +156,8 @@ const ArtificialShadowRootPrototype = create({}, ArtificialShadowRootDescriptors
 let DevModeBlackListDescriptorMap: PropertyDescriptorMap;
 
 if (process.env.NODE_ENV !== 'production') {
-    DevModeBlackListDescriptorMap = {
-        // TODO: do we really want this to return the component?
-        // It seems that we can remove this entirely to disable the access to the host from within.
-        host: {
-            get(this: ShadowRoot) {
-                const vm = getShadowRootVM(this);
-                return vm.component;
-            },
-        }
-    };
+    DevModeBlackListDescriptorMap = {};
+
     const BlackListedShadowRootMethods = {
         appendChild: 0,
         cloneNode: 0,

diff --git a/packages/lwc-engine/src/framework/dom/traverse.ts b/packages/lwc-engine/src/framework/dom/traverse.ts
@@ -105,10 +105,11 @@ const shadowDescriptors: PropertyDescriptorMap = {
         value: lightDomQuerySelectorAll,
         configurable: true,
     },
-    parentNode: {
-        get: parentNodeDescriptorValue,
-        configurable: true,
-    },
+    // TODO: @dval removes as a temporal fix for selenium internals
+    // parentNode: {
+    //     get: parentNodeDescriptorValue,
+    //     configurable: true,
+    // },
     parentElement: {
         get: parentElementDescriptorValue,
         configurable: true,

diff --git a/packages/lwc-engine/src/framework/html-element.ts b/packages/lwc-engine/src/framework/html-element.ts
@@ -30,6 +30,11 @@ function ElementShadowRootGetter(this: HTMLElement): ShadowRoot | null {
 }
 
 const fallbackDescriptors = {
+    shadowRoot: {
+        get: ElementShadowRootGetter,
+        configurable: true,
+        enumerable: true,
+    },
     querySelector: {
         value: lightDomQuerySelector,
         configurable: true,
@@ -146,13 +151,6 @@ function LWCElement(this: Component) {
     defineProperties(elm, def.descriptors);
     if (isTrue(fallback)) {
         defineProperties(elm, fallbackDescriptors);
-        if (process.env.NODE_ENV !== 'production') {
-            defineProperty(elm, 'shadowRoot', {
-                get: ElementShadowRootGetter,
-                configurable: true,
-                enumerable: true,
-            });
-        }
     }
 }