allow result features to be removed by raw feature filter #458
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leahmcguire
requested review from
gerashegalov,
Jauntbox,
tovbinm and
wsuchy
as code owners
Codecov Report
@@ Coverage Diff @@
## master #458 +/- ##
=========================================
Coverage ? 86.95%
=========================================
Files ? 340
Lines ? 11428
Branches ? 363
=========================================
Hits ? 9937
Misses ? 1491
Partials ? 0
Continue to review full report at Codecov.
|
tovbinm
approved these changes
Jan 22, 2020
| @@ -534,8 +549,10 @@ class OpWorkflow(val uid: String = UID[OpWorkflow]) extends OpWorkflowCore { | |||
| protectedJSFeatures: Array[OPFeature] = Array.empty, | |||
| textBinsFormula: (Summary, Int) => Int = RawFeatureFilter.textBinsFormula, | |||
| timePeriod: Option[TimePeriod] = None, | |||
| minScoringRows: Int = RawFeatureFilter.minScoringRowsDefault | |||
| minScoringRows: Int = RawFeatureFilter.minScoringRowsDefault, | |||
| finalFeatureRetentionPolicy: ResultFeatureRetention = ResultFeatureRetention.Strict | |||
There was a problem hiding this comment.
Rename finalFeatureRetentionPolicy to resultFeatureRetentionPolicy
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issues
Result features removed by raw feature filter throw an error, but sometimes we wish to allow them to be removed.
Describe the proposed solution
Created a flag that allows removal of result features by raw feature filter
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Additional context
Add any other context about the changes here.