Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

loco test bug fix #423

Open
wants to merge 15 commits into
base: master
Choose a base branch
from
Open
Changes from 11 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -233,8 +233,8 @@ class RecordInsightsLOCOTest extends FunSpec with TestSparkContext with RecordIn
info("Each feature vector should only have either three or four non-zero entries. One each from country and " +
"picklist, while currency can have either two (if it's null the currency column will be filled with the mean)" +
" or just one if it's not null.")
it("should pick between 1 and 4 of the features") {
all(parsed.map(_.size)) should (be >= 1 and be <= 4)
it("should pick between 0 and 4 features") {
all(parsed.map(_.size)) should (be >= 0 and be <= 4)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this seems like it is not checking very much... can you do a check for the conditions described above and then do the size check?

}

// Grab the feature vector metadata for comparison against the LOCO record insights
Expand Down