-
Notifications
You must be signed in to change notification settings - Fork 393
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
loco test bug fix #423
Open
AdamChit
wants to merge
15
commits into
salesforce:master
Choose a base branch
from
AdamChit:achit/LOCO-Test-Bug-Fix
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
loco test bug fix #423
Changes from 11 commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
a17c13c
Changes to FunSpec and refactored test
AdamChit b0cdfae
refactored test to make it more readable and changed to Funspec
AdamChit ebedf1d
Merge branch 'master' into LocoTestRefactor
AdamChit 96ec077
Changes to FunSpec and refactored test
AdamChit b3ca610
refactored test to make it more readable and changed to Funspec
AdamChit fb28e65
Merge branch 'LocoTestRefactor' of https://github.com/AdamChit/Transm…
AdamChit 3095e19
revert formatting to follow scala style
AdamChit 973aa0d
more descriptive title for section
AdamChit e31bd22
threshold was too large and would fail on some runs of the test
AdamChit acd97a6
fork sync
AdamChit 236bb7c
non of the features could be selected
AdamChit 3a9369f
Merge branch 'master' into achit/LOCO-Test-Bug-Fix
tovbinm 92c1e43
Merge branch 'master' into achit/LOCO-Test-Bug-Fix
tovbinm b4a2116
Merge branch 'master' into achit/LOCO-Test-Bug-Fix
tovbinm b6829fe
Merge branch 'master' into achit/LOCO-Test-Bug-Fix
tovbinm File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this seems like it is not checking very much... can you do a check for the conditions described above and then do the size check?