Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add FeatureDistribution to SerializationFormats #383

Merged
merged 2 commits into from
Aug 12, 2019

Conversation

TuanNguyen27
Copy link
Collaborator

Related issues
See pull request #354
#354 (comment)

Adding new classes to json serialization for FeatureDistribution

@codecov
Copy link

codecov bot commented Aug 12, 2019

Codecov Report

Merging #383 into master will increase coverage by 0.1%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #383     +/-   ##
=========================================
+ Coverage   86.73%   86.84%   +0.1%     
=========================================
  Files         336      336             
  Lines       10950    10950             
  Branches      351      580    +229     
=========================================
+ Hits         9497     9509     +12     
+ Misses       1453     1441     -12
Impacted Files Coverage Δ
...c/main/scala/com/salesforce/op/ModelInsights.scala 91.54% <ø> (ø) ⬆️
...es/src/main/scala/com/salesforce/op/OpParams.scala 85.71% <0%> (-4.09%) ⬇️
...cala/com/salesforce/op/cli/gen/FileGenerator.scala 77.27% <0%> (+3.03%) ⬆️
...ain/scala/com/salesforce/op/cli/SchemaSource.scala 87.93% <0%> (+5.17%) ⬆️
...src/main/scala/com/salesforce/op/cli/gen/Ops.scala 94% <0%> (+8%) ⬆️
...src/main/scala/com/salesforce/op/cli/CliExec.scala 80% <0%> (+25%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b634157...161e66e. Read the comment docs.

Copy link
Collaborator

@leahmcguire leahmcguire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

@TuanNguyen27 TuanNguyen27 merged commit 088e041 into master Aug 12, 2019
@TuanNguyen27 TuanNguyen27 deleted the tn/serialization branch August 12, 2019 16:29
@gerashegalov gerashegalov mentioned this pull request Sep 8, 2019
gerashegalov added a commit that referenced this pull request Sep 11, 2019
Bug fixes:
- Ensure correct metrics despite model failures on some CV folds [#404](#404)
- Fix flaky `ModelInsight` tests [#395](#395)
- Avoid creating `SparseVector`s for LOCO [#377](#377)

New features / updates:
- Model combiner [#385](#399)
- Added new sample for HousingPrices [#365](#365)
- Test to verify that custom metrics appear in model insight metrics [#387](#387)
- Add `FeatureDistribution` to `SerializationFormat`s [#383](#383)
- Add metadata to `OpStandadrdScaler` to allow for descaling [#378](#378)
- Improve json serde error in `evalMetFromJson` [#380](#380)
- Track mean & standard deviation as metrics for numeric features and for text length of text features [#354](#354)
- Making model selectors robust to failing models [#372](#372)
- Use compact and compressed model json by default [#375](#375)
- Descale feature contribution for Linear Regression & Logistic Regression [#345](#345)

Dependency updates:   
- Update tika version [#382](#382)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants