Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get rid of scalaj-collections #333

Merged
merged 3 commits into from
Jun 17, 2019
Merged

Get rid of scalaj-collections #333

merged 3 commits into from
Jun 17, 2019

Conversation

wsuchy
Copy link
Contributor

@wsuchy wsuchy commented Jun 14, 2019

There is no Scala 2.12 version of that library.

@codecov
Copy link

codecov bot commented Jun 14, 2019

Codecov Report

Merging #333 into master will decrease coverage by 0.04%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #333      +/-   ##
==========================================
- Coverage   86.58%   86.54%   -0.05%     
==========================================
  Files         335      335              
  Lines       10748    10751       +3     
  Branches      359      354       -5     
==========================================
- Hits         9306     9304       -2     
- Misses       1442     1447       +5
Impacted Files Coverage Δ
...ala/com/salesforce/op/features/types/package.scala 51.06% <0%> (-1.12%) ⬇️
...es/src/main/scala/com/salesforce/op/OpParams.scala 85.71% <0%> (-4.09%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 13ddb4f...5ab37ef. Read the comment docs.

@tovbinm tovbinm merged commit 9fee4d4 into master Jun 17, 2019
@tovbinm tovbinm deleted the ks/drop-scalaj-collection branch June 17, 2019 00:53
This was referenced Jul 10, 2019
@salesforce-cla
Copy link

Thanks for the contribution! Before we can merge this, we need @wsuchy to sign the Salesforce.com Contributor License Agreement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants