Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correctly pass main class for CLI sub project #321

Merged
merged 3 commits into from
May 16, 2019
Merged

Conversation

tovbinm
Copy link
Collaborator

@tovbinm tovbinm commented May 15, 2019

Related issues
Main class for CLI is set in the root build script

Describe the proposed solution
Correctly set the main class for CLI project + cleanup

Describe alternatives you've considered
NA

@tovbinm tovbinm requested a review from wsuchy May 15, 2019 21:52
@tovbinm tovbinm requested a review from leahmcguire as a code owner May 15, 2019 21:52
@tovbinm tovbinm changed the title Properly pass main class into CLI jar Correctly pass main class for CLI sub project May 15, 2019
@codecov
Copy link

codecov bot commented May 15, 2019

Codecov Report

Merging #321 into master will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #321      +/-   ##
==========================================
+ Coverage   86.44%   86.46%   +0.01%     
==========================================
  Files         327      327              
  Lines       10602    10602              
  Branches      336      336              
==========================================
+ Hits         9165     9167       +2     
+ Misses       1437     1435       -2
Impacted Files Coverage Δ
...es/src/main/scala/com/salesforce/op/OpParams.scala 89.79% <0%> (+4.08%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6f55dee...52cdd54. Read the comment docs.

@tovbinm tovbinm merged commit 7886a58 into master May 16, 2019
@tovbinm tovbinm deleted the mt/main-class branch May 16, 2019 17:53
This was referenced Jul 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants