Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add check to raw feature filter for removing all features #303

Merged
merged 4 commits into from
Apr 29, 2019

Conversation

crupley
Copy link
Contributor

@crupley crupley commented Apr 26, 2019

Related issues
Raw Feature Filter should throw exception when removing all features #302

Describe the proposed solution
Throw an exception when raw feature filter removes all features

Describe alternatives you've considered
In linked issue

Additional context
None

@codecov
Copy link

codecov bot commented Apr 26, 2019

Codecov Report

Merging #303 into master will decrease coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #303      +/-   ##
=========================================
- Coverage   86.42%   86.4%   -0.02%     
=========================================
  Files         322     322              
  Lines       10570   10572       +2     
  Branches      350     566     +216     
=========================================
  Hits         9135    9135              
- Misses       1435    1437       +2
Impacted Files Coverage Δ
...a/com/salesforce/op/filters/RawFeatureFilter.scala 92.93% <100%> (+0.07%) ⬆️
...es/src/main/scala/com/salesforce/op/OpParams.scala 85.71% <0%> (-4.09%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a2dc9cf...deeb68c. Read the comment docs.

Copy link
Contributor

@gerashegalov gerashegalov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@leahmcguire leahmcguire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tovbinm tovbinm merged commit 9333dcd into salesforce:master Apr 29, 2019
@crupley crupley deleted the cr/rffException branch April 30, 2019 15:53
@Jauntbox Jauntbox mentioned this pull request May 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants