Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spec-ifying NGramTest #297

Merged
merged 2 commits into from
Apr 19, 2019
Merged

Spec-ifying NGramTest #297

merged 2 commits into from
Apr 19, 2019

Conversation

snabar
Copy link
Contributor

@snabar snabar commented Apr 18, 2019

Changing the NGramTest to extend SwTransformerSpec

@salesforce-cla
Copy link

Thanks for the contribution! It looks like @snabar is an internal user so signing the CLA is not required. However, we need to confirm this.

@tovbinm
Copy link
Collaborator

tovbinm commented Apr 19, 2019

@snabar lgtm. something is off with the style. please fix

@codecov
Copy link

codecov bot commented Apr 19, 2019

Codecov Report

Merging #297 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #297   +/-   ##
=======================================
  Coverage   86.25%   86.25%           
=======================================
  Files         320      320           
  Lines       10471    10471           
  Branches      352      352           
=======================================
  Hits         9032     9032           
  Misses       1439     1439

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 48bc18d...e9b2b94. Read the comment docs.

@tovbinm
Copy link
Collaborator

tovbinm commented Apr 19, 2019

@snabar please sign the CLA

@snabar
Copy link
Contributor Author

snabar commented Apr 19, 2019

@tovbinm It took me to some google form to confirm that i was a salesforce employee, and i filled out the form.

@tovbinm tovbinm merged commit 9357a89 into master Apr 19, 2019
@tovbinm tovbinm deleted the NGramTest branch April 19, 2019 15:14
@Jauntbox Jauntbox mentioned this pull request May 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants