-
Notifications
You must be signed in to change notification settings - Fork 393
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed onSetInput so is always called with new input #280
Conversation
Codecov Report
@@ Coverage Diff @@
## master #280 +/- ##
=========================================
+ Coverage 86.39% 86.4% +0.01%
=========================================
Files 319 319
Lines 10450 10453 +3
Branches 354 561 +207
=========================================
+ Hits 9028 9032 +4
+ Misses 1422 1421 -1
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #280 +/- ##
===========================================
- Coverage 86.39% 60.14% -26.26%
===========================================
Files 319 319
Lines 10440 10692 +252
Branches 350 546 +196
===========================================
- Hits 9020 6431 -2589
- Misses 1420 4261 +2841
Continue to review full report at Codecov.
|
@leahmcguire there are some build failures you might want to look into. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Related issues
Metadata for transformers was not being updated when raw feature filter removed features
Describe the proposed solution
Moved onSetInput call into the base (internal) set input call
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Additional context
Add any other context about the changes here.