Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove old test to make Spark run out of memory #160

Merged
merged 2 commits into from
Oct 22, 2018
Merged

Conversation

Jauntbox
Copy link
Contributor

Related issues
None

Describe the proposed solution
This PR removes a test for checking if Spark runs out of memory when calculating a correlation matrix. This is unnecessary and unhelpful since there is no action to take if/when this test fails and it just takes up time. Will speed up builds a bit.

Describe alternatives you've considered
n/a

Additional context
n/a

…calculating a correlation matrix (this is unnecessary and unhelpful)
Copy link
Collaborator

@tovbinm tovbinm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@codecov
Copy link

codecov bot commented Oct 22, 2018

Codecov Report

Merging #160 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           master     #160    +/-   ##
========================================
  Coverage   85.75%   85.75%            
========================================
  Files         303      303            
  Lines        9912     9912            
  Branches      337      543   +206     
========================================
  Hits         8500     8500            
  Misses       1412     1412

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8264265...103e0ec. Read the comment docs.

@tovbinm tovbinm merged commit 0fcfccf into master Oct 22, 2018
@tovbinm tovbinm deleted the km/remove-bad-test branch October 22, 2018 21:37
ericwayman pushed a commit that referenced this pull request Feb 8, 2019
…calculating a correlation matrix (this is unnecessary and unhelpful) (#160)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants