fixed model insights exception when features are excluded from sanity… #147
Conversation
… checker correlation calculations
Codecov Report
@@ Coverage Diff @@
## master #147 +/- ##
==========================================
- Coverage 86.38% 86.36% -0.02%
==========================================
Files 299 299
Lines 9752 9750 -2
Branches 343 550 +207
==========================================
- Hits 8424 8421 -3
- Misses 1328 1329 +1
Continue to review full report at Codecov.
|
| @@ -152,6 +153,22 @@ class ModelInsightsTest extends FlatSpec with PassengerSparkFixtureTest { | |||
| insights.stageInfo.keys.size shouldEqual 8 | |||
| } | |||
|
|
|||
| it should "return model insights even when correlation is turned off for some features" in { | |||
| val featuresFinal = Seq(description.vectorize(10, false, 1, true), | |||
There was a problem hiding this comment.
can you please name the arguments to vectorize calls.
|
Thanks for the contribution! Unfortunately we can't verify the commit author(s): leahmcguire <l***@s***.com> Leah McGuire <l***@s***.com>. One possible solution is to add that email to your GitHub account. Alternatively you can change your commits to another email and force push the change. After getting your commits associated with your GitHub account, refresh the status of this Pull Request. |
… checker correlation calculations
Related issues
Model insights used to throw runtime exception if a feature was not in the sanity checker correlation computation. However some features can be excluded from these calculations for performance so this was a problem.
Describe the proposed solution
If the feature is not found in the sanity checker calculations a None is returned for correlation.